2015-12-11 12:50:57

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH 0/2] ARM: OMAP1/2+: DO not create omap-pcm-audio device

Hi,

The ASoC omap-pcm has been converted to be non platform device a long time ago,
so it is no longer needed to create the device for it since there will be no
driver to be loaded for it.

Regards,
Peter
---
Peter Ujfalusi (2):
ARM: OMAP1: Remove device creation for omap-pcm-audio
ARM: OMAP2+: Remove device creation for omap-pcm-audio

arch/arm/mach-omap1/devices.c | 19 -------------------
arch/arm/mach-omap2/devices.c | 25 ++++---------------------
2 files changed, 4 insertions(+), 40 deletions(-)

--
2.6.4


2015-12-11 12:51:16

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH 1/2] ARM: OMAP1: Remove device creation for omap-pcm-audio

The omap-pcm in ASoC is no longer a platform device. No need to create this
device anymore.

Signed-off-by: Peter Ujfalusi <[email protected]>
---
arch/arm/mach-omap1/devices.c | 19 -------------------
1 file changed, 19 deletions(-)

diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c
index 263c07a566cb..8c8be861fff2 100644
--- a/arch/arm/mach-omap1/devices.c
+++ b/arch/arm/mach-omap1/devices.c
@@ -33,24 +33,6 @@
#include "mmc.h"
#include "sram.h"

-#if defined(CONFIG_SND_SOC) || defined(CONFIG_SND_SOC_MODULE)
-
-static struct platform_device omap_pcm = {
- .name = "omap-pcm-audio",
- .id = -1,
-};
-
-static void omap_init_audio(void)
-{
- platform_device_register(&omap_pcm);
-}
-
-#else
-static inline void omap_init_audio(void) {}
-#endif
-
-/*-------------------------------------------------------------------------*/
-
#if defined(CONFIG_RTC_DRV_OMAP) || defined(CONFIG_RTC_DRV_OMAP_MODULE)

#define OMAP_RTC_BASE 0xfffb4800
@@ -425,7 +407,6 @@ static int __init omap1_init_devices(void)
* in alphabetical order so they're easier to sort through.
*/

- omap_init_audio();
omap_init_mbox();
omap_init_rtc();
omap_init_spi100k();
--
2.6.4

2015-12-11 12:50:55

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH 2/2] ARM: OMAP2+: Remove device creation for omap-pcm-audio

The omap-pcm in ASoC is no longer a platform device. No need to create this
device anymore.

Signed-off-by: Peter Ujfalusi <[email protected]>
---
arch/arm/mach-omap2/devices.c | 25 ++++---------------------
1 file changed, 4 insertions(+), 21 deletions(-)

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 9374da313e8e..9cda974a3009 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -94,22 +94,6 @@ static inline void omap_init_mbox(void) { }

static inline void omap_init_sti(void) {}

-#if defined(CONFIG_SND_SOC) || defined(CONFIG_SND_SOC_MODULE)
-
-static struct platform_device omap_pcm = {
- .name = "omap-pcm-audio",
- .id = -1,
-};
-
-static void omap_init_audio(void)
-{
- platform_device_register(&omap_pcm);
-}
-
-#else
-static inline void omap_init_audio(void) {}
-#endif
-
#if defined(CONFIG_SPI_OMAP24XX) || defined(CONFIG_SPI_OMAP24XX_MODULE)

#include <linux/platform_data/spi-omap2-mcspi.h>
@@ -239,13 +223,12 @@ static int __init omap2_init_devices(void)
if (!of_have_populated_dt())
pinctrl_provide_dummies();

- /*
- * please keep these calls, and their implementations above,
- * in alphabetical order so they're easier to sort through.
- */
- omap_init_audio();
/* If dtb is there, the devices will be created dynamically */
if (!of_have_populated_dt()) {
+ /*
+ * please keep these calls, and their implementations above,
+ * in alphabetical order so they're easier to sort through.
+ */
omap_init_mbox();
omap_init_mcspi();
omap_init_sham();
--
2.6.4

2015-12-17 18:36:32

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 0/2] ARM: OMAP1/2+: DO not create omap-pcm-audio device

* Peter Ujfalusi <[email protected]> [151211 04:51]:
> Hi,
>
> The ASoC omap-pcm has been converted to be non platform device a long time ago,
> so it is no longer needed to create the device for it since there will be no
> driver to be loaded for it.

OK, applying into omap-for-v4.5/soc-v2 thanks.

Tony