LinuxLists.cc - linux-next: Fixes tag needs some work in the bpf-next tree

2019-08-16 13:47:51

Subject: linux-next: Fixes tag needs some work in the bpf-next tree

Hi all,

In commit

ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")

Fixes tag

Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")

has these problem(s):

- missing space between the SHA1 and the subject

This is dues to the trailing 't' on the SHA1 :-(

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2019-08-16 14:36:49

by Quentin Monnet

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the bpf-next tree

2019-08-16 23:46 UTC+1000 ~ Stephen Rothwell <[email protected]>
> Hi all,
>
> In commit
>
> ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")
>
> Fixes tag
>
> Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")
>
> has these problem(s):
>
> - missing space between the SHA1 and the subject
>
> This is dues to the trailing 't' on the SHA1 :-(
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>

Hi Stephen,

I made that typo, please accept my apologies :(.

The correct tag should be:

Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")

Regards,
Quentin