2015-12-18 03:02:57

by Bayi Cheng

Subject: [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function

Move write data register before excute command to avoid
missing first byte write to nor flash

Signed-off-by: Bayi Cheng <[email protected]>
---
the previous patch didn't drop the Change-Id

---
drivers/mtd/spi-nor/mtk-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c b/drivers/mtd/spi-nor/mtk-quadspi.c
index dd269650..04da971 100644
--- a/drivers/mtd/spi-nor/mtk-quadspi.c
+++ b/drivers/mtd/spi-nor/mtk-quadspi.c
@@ -272,10 +272,10 @@ static int mt8173_nor_write_single_byte(struct mt8173_nor *mt8173_nor,
mt8173_nor_set_addr(mt8173_nor, addr);

for (i = 0; i < length; i++) {
+ writeb(*data++, mt8173_nor->base + MTK_NOR_WDATA_REG);
ret = mt8173_nor_execute_cmd(mt8173_nor, MTK_NOR_PIO_WR_CMD);
if (ret < 0)
return ret;
- writeb(*data++, mt8173_nor->base + MTK_NOR_WDATA_REG);
}
return 0;
}
--
1.8.1.1.dirty

2015-12-18 23:06:11

by Brian Norris

Subject: Re: [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function

On Fri, Dec 18, 2015 at 11:02:40AM +0800, Bayi Cheng wrote:
> Move write data register before excute command to avoid
> missing first byte write to nor flash
>
> Signed-off-by: Bayi Cheng <[email protected]>
> ---
> the previous patch didn't drop the Change-Id

Applied to l2-mtd.git