2015-12-29 13:25:13

by bojan prtvar

Subject: [PATCH] resources: Remove unneeded initialization of local variable

Few lines below dr is reinitialized by devres_alloc()
so we don't need to init it by NULL in the beginning of
__devm_request_region()

Signed-off-by: Bojan Prtvar <[email protected]>
---
kernel/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index f150dbb..1e48ede 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1356,7 +1356,7 @@ struct resource * __devm_request_region(struct device *dev,
struct resource *parent, resource_size_t start,
resource_size_t n, const char *name)
{
- struct region_devres *dr = NULL;
+ struct region_devres *dr;
struct resource *res;

dr = devres_alloc(devm_region_release, sizeof(struct region_devres),
--
2.4.1

2015-12-29 13:36:19

by Laurent Navet

Subject: Re: [PATCH] resources: Remove unneeded initialization of local variable

why not directly ?

struct region_devres *dr = devres_alloc(devm_region_release,
sizeof(struct region_devres),..



2015-12-29 14:24 UTC+01:00, Bojan Prtvar <[email protected]>:
> Few lines below dr is reinitialized by devres_alloc()
> so we don't need to init it by NULL in the beginning of
> __devm_request_region()
>
> Signed-off-by: Bojan Prtvar <[email protected]>
> ---
> kernel/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index f150dbb..1e48ede 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -1356,7 +1356,7 @@ struct resource * __devm_request_region(struct device
> *dev,
> struct resource *parent, resource_size_t start,
> resource_size_t n, const char *name)
> {
> - struct region_devres *dr = NULL;
> + struct region_devres *dr;
> struct resource *res;
>
> dr = devres_alloc(devm_region_release, sizeof(struct region_devres),
> --
> 2.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors"
> in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


--
« On ne résout pas un problème avec les modes de pensée qui l’ont engendré. »
« You cannot solve current problems with current thinking. Current
problems are the result of current thinking »

2015-12-29 15:04:48

by bojan prtvar

Subject: Re: [PATCH] resources: Remove unneeded initialization of local variable

On Tue, Dec 29, 2015 at 2:36 PM, Laurent Navet <[email protected]> wrote:
> why not directly ?
>
> struct region_devres *dr = devres_alloc(devm_region_release,
> sizeof(struct region_devres),..
>

I follow Dan's rationale [1]

[1]
http://www.spinics.net/lists/target-devel/msg11355.html