2016-03-01 19:31:55

by Timur Tabi

Subject: [PATCH] acpi: pnp: add ACPI_RESOURCE_TYPE_SERIAL_BUS as a valid type

From: Harb Abdulhamid <[email protected]>

An error message is printed for resources of type 19, which is a valid
supported resource type. The Firmware Test Suite tool (fwts) reports
this as a test failure. This change fixes the false test failures
for ASL that use type 19 (ACPI_RESOURCE_TYPE_SERIAL_BUS) resources.

Signed-off-by: Harb Abdulhamid <[email protected]>
Signed-off-by: Timur Tabi <[email protected]>
---
drivers/pnp/pnpacpi/rsparser.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/pnp/pnpacpi/rsparser.c b/drivers/pnp/pnpacpi/rsparser.c
index 0579649..4b717c6 100644
--- a/drivers/pnp/pnpacpi/rsparser.c
+++ b/drivers/pnp/pnpacpi/rsparser.c
@@ -252,6 +252,10 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
break;

+ case ACPI_RESOURCE_TYPE_SERIAL_BUS:
+ /* serial bus connections (I2C/SPI/UART) are not pnp */
+ break;
+
default:
dev_warn(&dev->dev, "unknown resource type %d in _CRS\n",
res->type);
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

2016-03-10 23:35:09

by Rafael J. Wysocki

Subject: Re: [PATCH] acpi: pnp: add ACPI_RESOURCE_TYPE_SERIAL_BUS as a valid type

On Tuesday, March 01, 2016 01:31:45 PM Timur Tabi wrote:
> From: Harb Abdulhamid <[email protected]>
>
> An error message is printed for resources of type 19, which is a valid
> supported resource type. The Firmware Test Suite tool (fwts) reports
> this as a test failure. This change fixes the false test failures
> for ASL that use type 19 (ACPI_RESOURCE_TYPE_SERIAL_BUS) resources.
>
> Signed-off-by: Harb Abdulhamid <[email protected]>
> Signed-off-by: Timur Tabi <[email protected]>

Applied, thanks!

Rafael