2016-03-03 16:39:09

by Philip Elcan

Subject: [PATCH] mmc: sdhci-acpi: add QCOM controllers

This adds the HIDs for Qualcomm Technologies Inc SDHC
controllers:
QCOM8051: non-removable device that does not support 1.8v
QCOM8052: non-removable device that does support 1.8v

Signed-off-by: Philip Elcan <[email protected]>
---
drivers/mmc/host/sdhci-acpi.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index a5cda92..041e739 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -264,6 +264,17 @@ static const struct sdhci_acpi_slot sdhci_acpi_slot_int_sd = {
.probe_slot = sdhci_acpi_sd_probe_slot,
};

+static const struct sdhci_acpi_slot sdhci_acpi_slot_qcom_sd_3v = {
+ .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION,
+ .quirks2 = SDHCI_QUIRK2_NO_1_8_V,
+ .caps = MMC_CAP_NONREMOVABLE,
+};
+
+static const struct sdhci_acpi_slot sdhci_acpi_slot_qcom_sd = {
+ .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION,
+ .caps = MMC_CAP_NONREMOVABLE,
+};
+
struct sdhci_acpi_uid_slot {
const char *hid;
const char *uid;
@@ -284,6 +295,8 @@ static const struct sdhci_acpi_uid_slot sdhci_acpi_uids[] = {
{ "INT344D" , NULL, &sdhci_acpi_slot_int_sdio },
{ "PNP0FFF" , "3" , &sdhci_acpi_slot_int_sd },
{ "PNP0D40" },
+ { "QCOM8051", NULL, &sdhci_acpi_slot_qcom_sd_3v },
+ { "QCOM8052", NULL, &sdhci_acpi_slot_qcom_sd },
{ },
};

@@ -298,6 +311,8 @@ static const struct acpi_device_id sdhci_acpi_ids[] = {
{ "INT3436" },
{ "INT344D" },
{ "PNP0D40" },
+ { "QCOM8051" },
+ { "QCOM8052" },
{ },
};
MODULE_DEVICE_TABLE(acpi, sdhci_acpi_ids);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2016-03-08 14:01:30

by Adrian Hunter

Subject: Re: [PATCH] mmc: sdhci-acpi: add QCOM controllers

On 03/03/16 18:38, Philip Elcan wrote:
> This adds the HIDs for Qualcomm Technologies Inc SDHC
> controllers:
> QCOM8051: non-removable device that does not support 1.8v
> QCOM8052: non-removable device that does support 1.8v
>
> Signed-off-by: Philip Elcan <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

2016-03-16 11:37:50

by Ulf Hansson

Subject: Re: [PATCH] mmc: sdhci-acpi: add QCOM controllers

On 3 March 2016 at 17:38, Philip Elcan <[email protected]> wrote:
> This adds the HIDs for Qualcomm Technologies Inc SDHC
> controllers:
> QCOM8051: non-removable device that does not support 1.8v
> QCOM8052: non-removable device that does support 1.8v
>
> Signed-off-by: Philip Elcan <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci-acpi.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index a5cda92..041e739 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -264,6 +264,17 @@ static const struct sdhci_acpi_slot sdhci_acpi_slot_int_sd = {
> .probe_slot = sdhci_acpi_sd_probe_slot,
> };
>
> +static const struct sdhci_acpi_slot sdhci_acpi_slot_qcom_sd_3v = {
> + .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION,
> + .quirks2 = SDHCI_QUIRK2_NO_1_8_V,
> + .caps = MMC_CAP_NONREMOVABLE,
> +};
> +
> +static const struct sdhci_acpi_slot sdhci_acpi_slot_qcom_sd = {
> + .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION,
> + .caps = MMC_CAP_NONREMOVABLE,
> +};
> +
> struct sdhci_acpi_uid_slot {
> const char *hid;
> const char *uid;
> @@ -284,6 +295,8 @@ static const struct sdhci_acpi_uid_slot sdhci_acpi_uids[] = {
> { "INT344D" , NULL, &sdhci_acpi_slot_int_sdio },
> { "PNP0FFF" , "3" , &sdhci_acpi_slot_int_sd },
> { "PNP0D40" },
> + { "QCOM8051", NULL, &sdhci_acpi_slot_qcom_sd_3v },
> + { "QCOM8052", NULL, &sdhci_acpi_slot_qcom_sd },
> { },
> };
>
> @@ -298,6 +311,8 @@ static const struct acpi_device_id sdhci_acpi_ids[] = {
> { "INT3436" },
> { "INT344D" },
> { "PNP0D40" },
> + { "QCOM8051" },
> + { "QCOM8052" },
> { },
> };
> MODULE_DEVICE_TABLE(acpi, sdhci_acpi_ids);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>