2016-03-06 04:37:24

by Purna Chandra Mandal

[permalink] [raw]
Subject: [RESEND PATCH v2 1/2] dt/bindings: Add bindings for PIC32 SPI peripheral

Signed-off-by: Purna Chandra Mandal <[email protected]>

---

Changes in v2:
- fix indentation
- add space after comma
- moved 'cs-gpios' section under 'required' properties.

.../bindings/spi/microchip,spi-pic32.txt | 34 ++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt

diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
new file mode 100644
index 0000000..79de379f
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
@@ -0,0 +1,34 @@
+Microchip PIC32 SPI Master controller
+
+Required properties:
+- compatible: Should be "microchip,pic32mzda-spi".
+- reg: Address and length of register space for the device.
+- interrupts: Should contain all three spi interrupts in sequence
+ of <fault-irq>, <receive-irq>, <transmit-irq>.
+- interrupt-names: Should be "fault", "rx", "tx" in order.
+- clocks: Phandle of the clock generating SPI clock on the bus.
+- clock-names: Should be "mck0".
+- cs-gpios: Specifies the gpio pins to be used for chipselects.
+ See: Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Optional properties:
+- dmas: Two or more DMA channel specifiers following the convention outlined
+ in Documentation/devicetree/bindings/dma/dma.txt
+- dma-names: Names for the dma channels. There must be at least one channel
+ named "spi-tx" for transmit and named "spi-rx" for receive.
+
+Example:
+
+spi1: spi@1f821000 {
+ compatible = "microchip,pic32mzda-spi";
+ reg = <0x1f821000 0x200>;
+ interrupts = <109 IRQ_TYPE_LEVEL_HIGH>,
+ <110 IRQ_TYPE_LEVEL_HIGH>,
+ <111 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "fault", "rx", "tx";
+ clocks = <&PBCLK2>;
+ clock-names = "mck0";
+ cs-gpios = <&gpio3 4 GPIO_ACTIVE_LOW>;
+ dmas = <&dma 134>, <&dma 135>;
+ dma-names = "spi-rx", "spi-tx";
+};
--
1.8.3.1


2016-03-06 11:34:18

by Mark Brown

[permalink] [raw]
Subject: Re: [RESEND PATCH v2 1/2] dt/bindings: Add bindings for PIC32 SPI peripheral

On Sun, Mar 06, 2016 at 10:05:26AM +0530, Purna Chandra Mandal wrote:
> Signed-off-by: Purna Chandra Mandal <[email protected]>
>
> ---
>
> Changes in v2:
> - fix indentation
> - add space after comma
> - moved 'cs-gpios' section under 'required' properties.

Please send the *whole* series so I can keep track of which things go
together. There's no need to put noise words like RESEND in the subject
line.


Attachments:
(No filename) (423.00 B)
signature.asc (473.00 B)
Download all attachments

2016-03-17 12:00:56

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [RESEND PATCH v2 1/2] dt/bindings: Add bindings for PIC32 SPI peripheral

On Sun, Mar 06, 2016 at 10:05:26AM +0530, Purna Chandra Mandal wrote:
> Signed-off-by: Purna Chandra Mandal <[email protected]>
>
> ---
>
> Changes in v2:
> - fix indentation
> - add space after comma
> - moved 'cs-gpios' section under 'required' properties.
>
> .../bindings/spi/microchip,spi-pic32.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt

Acked-by: Rob Herring <[email protected]>