2016-03-10 05:30:59

by Neha Rani

Subject: [PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' found by checkpatch.pl tool

Signed-off-by: Neha Rani <[email protected]>
---
drivers/atm/fore200e.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 75dde90..fac5e4fd 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -409,7 +409,7 @@ fore200e_shutdown(struct fore200e* fore200e)
static u32 fore200e_pca_read(volatile u32 __iomem *addr)
{
/* on big-endian hosts, the board is configured to convert
- the endianess of slave RAM accesses */
+ the endianness of slave RAM accesses */
return le32_to_cpu(readl(addr));
}

@@ -417,7 +417,7 @@ static u32 fore200e_pca_read(volatile u32 __iomem *addr)
static void fore200e_pca_write(u32 val, volatile u32 __iomem *addr)
{
/* on big-endian hosts, the board is configured to convert
- the endianess of slave RAM accesses */
+ the endianness of slave RAM accesses */
writel(cpu_to_le32(val), addr);
}

@@ -577,7 +577,7 @@ static int fore200e_pca_configure(struct fore200e *fore200e)

master_ctrl = master_ctrl
#if defined(__BIG_ENDIAN)
- /* request the PCA board to convert the endianess of slave RAM accesses */
+ /* request the PCA board to convert the endianness of slave RAM accesses */
| PCA200E_CTRL_CONVERT_ENDIAN
#endif
#if 0
--
2.5.0

2016-03-10 06:17:54

by Amitoj Kaur Chawla

Subject: Re: [PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' found by checkpatch.pl tool

On Thu, Mar 10, 2016 at 11:00 AM, rneha725 <[email protected]> wrote:
> Signed-off-by: Neha Rani <[email protected]>
> ---
Hi Neha,

You should ideally submit patches for drivers/staging/ as a newbie and
not other drivers.

Other than that,
Your subject is too long and you haven't written a commit message,

A better way to write the subject would be `atm: Fix spelling of endianness `

The commit message can contain the other details like this:
This patch fixes the spelling of 'endianness'. Problem found by
checkpatch.pl tool
<Insert checkpatch.pl warning here>

Also your From should contain your full legal name like your Signed
Off instead of rneha725.
Same comments for patch 2/2.

> drivers/atm/fore200e.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
> index 75dde90..fac5e4fd 100644
> --- a/drivers/atm/fore200e.c
> +++ b/drivers/atm/fore200e.c
> @@ -409,7 +409,7 @@ fore200e_shutdown(struct fore200e* fore200e)
> static u32 fore200e_pca_read(volatile u32 __iomem *addr)
> {
> /* on big-endian hosts, the board is configured to convert
> - the endianess of slave RAM accesses */
> + the endianness of slave RAM accesses */
> return le32_to_cpu(readl(addr));
> }
>
> @@ -417,7 +417,7 @@ static u32 fore200e_pca_read(volatile u32 __iomem *addr)
> static void fore200e_pca_write(u32 val, volatile u32 __iomem *addr)
> {
> /* on big-endian hosts, the board is configured to convert
> - the endianess of slave RAM accesses */
> + the endianness of slave RAM accesses */
> writel(cpu_to_le32(val), addr);
> }
>
> @@ -577,7 +577,7 @@ static int fore200e_pca_configure(struct fore200e *fore200e)
>
> master_ctrl = master_ctrl
> #if defined(__BIG_ENDIAN)
> - /* request the PCA board to convert the endianess of slave RAM accesses */
> + /* request the PCA board to convert the endianness of slave RAM accesses */
> | PCA200E_CTRL_CONVERT_ENDIAN
> #endif
> #if 0
> --
> 2.5.0
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel