2016-03-10 12:59:16

by Corentin Labbe

Subject: [PATCH v2] phy: remove documentation of removed members of phy_device structure

Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
bus and dev member of the phy_device structure.
This patch remove the documentation about those members.

Signed-off-by: LABBE Corentin <[email protected]>
---
include/linux/phy.h | 3 ---
1 file changed, 3 deletions(-)

Changes since v1
- remove also documentation for dev and bus

diff --git a/include/linux/phy.h b/include/linux/phy.h
index d6f3641..2abd791 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -327,8 +327,6 @@ struct phy_c45_device_ids {
/* phy_device: An instance of a PHY
*
* drv: Pointer to the driver for this PHY instance
- * bus: Pointer to the bus this PHY is on
- * dev: driver model device structure for this PHY
* phy_id: UID for this device found during discovery
* c45_ids: 802.3-c45 Device Identifers if is_c45.
* is_c45: Set to true if this phy uses clause 45 addressing.
@@ -338,7 +336,6 @@ struct phy_c45_device_ids {
* suspended: Set to true if this phy has been suspended successfully.
* state: state of the PHY for management purposes
* dev_flags: Device-specific flags used by the PHY driver.
- * addr: Bus address of PHY
* link_timeout: The number of timer firings to wait before the
* giving up on the current attempt at acquiring a link
* irq: IRQ number of the PHY's interrupt (-1 if none)
--
2.4.10

2016-03-10 14:22:06

by Andrew Lunn

Subject: Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

On Thu, Mar 10, 2016 at 01:58:58PM +0100, LABBE Corentin wrote:
> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
>
> Signed-off-by: LABBE Corentin <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Hi Corentin

Thanks for updating the patch with the extra removals.

Andrew

> ---
> include/linux/phy.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> Changes since v1
> - remove also documentation for dev and bus
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index d6f3641..2abd791 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -327,8 +327,6 @@ struct phy_c45_device_ids {
> /* phy_device: An instance of a PHY
> *
> * drv: Pointer to the driver for this PHY instance
> - * bus: Pointer to the bus this PHY is on
> - * dev: driver model device structure for this PHY
> * phy_id: UID for this device found during discovery
> * c45_ids: 802.3-c45 Device Identifers if is_c45.
> * is_c45: Set to true if this phy uses clause 45 addressing.
> @@ -338,7 +336,6 @@ struct phy_c45_device_ids {
> * suspended: Set to true if this phy has been suspended successfully.
> * state: state of the PHY for management purposes
> * dev_flags: Device-specific flags used by the PHY driver.
> - * addr: Bus address of PHY
> * link_timeout: The number of timer firings to wait before the
> * giving up on the current attempt at acquiring a link
> * irq: IRQ number of the PHY's interrupt (-1 if none)
> --
> 2.4.10
>

2016-03-10 17:55:32

by Florian Fainelli

Subject: Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

On 10/03/16 04:58, LABBE Corentin wrote:
> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
>
> Signed-off-by: LABBE Corentin <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2016-03-14 02:12:04

by David Miller

Subject: Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

From: LABBE Corentin <[email protected]>
Date: Thu, 10 Mar 2016 13:58:58 +0100

> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
>
> Signed-off-by: LABBE Corentin <[email protected]>

Applied.