2016-03-15 00:19:03

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH v7] rtc: rewrite DS1302 using SPI

Hi,

Thank you for your work!

On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote :
> -#ifdef CONFIG_SH_SECUREEDGE5410
> -#include <asm/rtc.h>
> -#include <mach/secureedge5410.h>
> -
> -#define RTC_RESET 0x1000
> -#define RTC_IODATA 0x0800
> -#define RTC_SCLK 0x0400
> -
> -#define set_dp(x) SECUREEDGE_WRITE_IOPORT(x, 0x1c00)
> -#define get_dp() SECUREEDGE_READ_IOPORT()
> -#define ds1302_set_tx()
> -#define ds1302_set_rx()
> -

I would like to have a solution for secureedge5410 even if it is
untested. Else, we are breaking an existing platform without any
solution.

I've put the sh maintainers in copy, maybe they have an opinion. Else
I'll let your patch sit in linux-next for the next cycle.

I have further cleanups in that driver but they can probably be done
later.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


2016-03-18 10:38:28

by Sergei Ianovich

[permalink] [raw]
Subject: Re: [PATCH v7] rtc: rewrite DS1302 using SPI

On Tue, 2016-03-15 at 01:18 +0100, Alexandre Belloni wrote:
> I would like to have a solution for secureedge5410 even if it is
> untested. Else, we are breaking an existing platform without any
> solution.
>
> I've put the sh maintainers in copy, maybe they have an opinion. Else
> I'll let your patch sit in linux-next for the next cycle.

secureedge5410 will need an SPI host driver. The driver will be similar
to the one I did for lp8841. I can make a clone for secureedge5410, but
I cannot test it.

The only reason, I didn't file the patch for secureedge5410, is I
thought SPI people won't accept an untested patch.