2016-03-22 04:10:15

by Wei-Ning Huang

[permalink] [raw]
Subject: [PATCH v2] mwifiex: advertise low priority scan feature

From: Amitkumar Karwar <[email protected]>

Low priority scan handling code which delays or aborts scan
operation based on Tx traffic is removed recently. The reason
is firmware already takes care of it in our new feature scan
channel gap. Hence we should advertise low priority scan
support to cfg80211.

This patch fixes a problem in which OBSS scan request from
wpa_supplicant was being rejected by cfg80211.

Signed-off-by: Amitkumar Karwar <[email protected]>
Signed-off-by: Wei-Ning Huang <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index bb7235e..7dafc5b 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)

wiphy->features |= NL80211_FEATURE_HT_IBSS |
NL80211_FEATURE_INACTIVITY_TIMER |
+ NL80211_FEATURE_LOW_PRIORITY_SCAN |
NL80211_FEATURE_NEED_OBSS_SCAN;

if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
--
2.8.0.rc3.226.g39d4020


2016-03-22 04:13:02

by Wei-Ning Huang

[permalink] [raw]
Subject: Re: [PATCH v2] mwifiex: advertise low priority scan feature

Tested-by: Wei-Ning Huang <[email protected]>

On Tue, Mar 22, 2016 at 12:09 PM, Wei-Ning Huang <[email protected]> wrote:
> From: Amitkumar Karwar <[email protected]>
>
> Low priority scan handling code which delays or aborts scan
> operation based on Tx traffic is removed recently. The reason
> is firmware already takes care of it in our new feature scan
> channel gap. Hence we should advertise low priority scan
> support to cfg80211.
>
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
>
> Signed-off-by: Amitkumar Karwar <[email protected]>
> Signed-off-by: Wei-Ning Huang <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index bb7235e..7dafc5b 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
>
> wiphy->features |= NL80211_FEATURE_HT_IBSS |
> NL80211_FEATURE_INACTIVITY_TIMER |
> + NL80211_FEATURE_LOW_PRIORITY_SCAN |
> NL80211_FEATURE_NEED_OBSS_SCAN;
>
> if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
> --
> 2.8.0.rc3.226.g39d4020
>



--
Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan |
[email protected] | Cell: +886 910-380678

2016-03-24 17:00:36

by Amitkumar Karwar

[permalink] [raw]
Subject: RE: [PATCH v2] mwifiex: advertise low priority scan feature

> From: Wei-Ning Huang [mailto:[email protected]]
> Sent: Tuesday, March 22, 2016 9:40 AM
> To: Linux Wireless
> Cc: LKML; Amitkumar Karwar; [email protected]; Wei-Ning Huang;
> Nishant Sarmukadam; [email protected]; [email protected]
> Subject: [PATCH v2] mwifiex: advertise low priority scan feature
>
> From: Amitkumar Karwar <[email protected]>
>
> Low priority scan handling code which delays or aborts scan operation
> based on Tx traffic is removed recently. The reason is firmware already
> takes care of it in our new feature scan channel gap. Hence we should
> advertise low priority scan support to cfg80211.
>
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
>
> Signed-off-by: Amitkumar Karwar <[email protected]>
> Signed-off-by: Wei-Ning Huang <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index bb7235e..7dafc5b 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct
> mwifiex_adapter *adapter)
>
> wiphy->features |= NL80211_FEATURE_HT_IBSS |
> NL80211_FEATURE_INACTIVITY_TIMER |
> + NL80211_FEATURE_LOW_PRIORITY_SCAN |
> NL80211_FEATURE_NEED_OBSS_SCAN;
>
> if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
> --
> 2.8.0.rc3.226.g39d4020

Acked-by: Amitkumar Karwar <[email protected]>

Regards,
Amitkumar

2016-04-06 18:43:40

by Kalle Valo

[permalink] [raw]
Subject: Re: [v2] mwifiex: advertise low priority scan feature


> From: Amitkumar Karwar <[email protected]>
>
> Low priority scan handling code which delays or aborts scan
> operation based on Tx traffic is removed recently. The reason
> is firmware already takes care of it in our new feature scan
> channel gap. Hence we should advertise low priority scan
> support to cfg80211.
>
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
>
> Signed-off-by: Amitkumar Karwar <[email protected]>
> Signed-off-by: Wei-Ning Huang <[email protected]>
> Tested-by: Wei-Ning Huang <[email protected]>
> Acked-by: Amitkumar Karwar <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo