2016-03-23 22:05:38

by Matthew McClintock

[permalink] [raw]
Subject: [PATCH 01/17] pinctrl: qcom: ipq4019: set ngpios to correct value

This should have been bumped to 100 when the extra pins
were added in the original pinctrl patch

CC: [email protected]
CC: [email protected]
Signed-off-by: Matthew McClintock <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
index b5d81ce..cb5f0a8 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
@@ -414,7 +414,7 @@ static const struct msm_pinctrl_soc_data ipq4019_pinctrl = {
.nfunctions = ARRAY_SIZE(ipq4019_functions),
.groups = ipq4019_groups,
.ngroups = ARRAY_SIZE(ipq4019_groups),
- .ngpios = 70,
+ .ngpios = 100,
};

static int ipq4019_pinctrl_probe(struct platform_device *pdev)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2016-03-25 21:19:50

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 01/17] pinctrl: qcom: ipq4019: set ngpios to correct value

On Wed 23 Mar 15:04 PDT 2016, Matthew McClintock wrote:

> This should have been bumped to 100 when the extra pins
> were added in the original pinctrl patch
>
> CC: [email protected]

Sorry for missing this in the initial review of this driver.

Acked-by: [email protected]

Regards,
Bjorn

> Signed-off-by: Matthew McClintock <[email protected]>
> ---
> drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> index b5d81ce..cb5f0a8 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> @@ -414,7 +414,7 @@ static const struct msm_pinctrl_soc_data ipq4019_pinctrl = {
> .nfunctions = ARRAY_SIZE(ipq4019_functions),
> .groups = ipq4019_groups,
> .ngroups = ARRAY_SIZE(ipq4019_groups),
> - .ngpios = 70,
> + .ngpios = 100,
> };
>
> static int ipq4019_pinctrl_probe(struct platform_device *pdev)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

2016-03-31 09:53:53

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 01/17] pinctrl: qcom: ipq4019: set ngpios to correct value

On Wed, Mar 23, 2016 at 11:04 PM, Matthew McClintock
<[email protected]> wrote:

> This should have been bumped to 100 when the extra pins
> were added in the original pinctrl patch
>
> CC: [email protected]
> CC: [email protected]
> Signed-off-by: Matthew McClintock <[email protected]>

Patch applied for fixes with Björn's ACK.

Yours,
Linus Walleij