2016-03-25 17:04:12

by Vivien Didelot

[permalink] [raw]
Subject: [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging

The 88E6185 switch also has a MapDA bit in its Port Control 2 register.
When this bit is cleared, all frames are sent out to the CPU port.

Set this bit to rely on ATU hits and direct the frame out of the correct
ports, and thus enable hardware bridging.

Signed-off-by: Vivien Didelot <[email protected]>
---
drivers/net/dsa/mv88e6xxx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 4332b15..85ed3e2 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2586,7 +2586,8 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
reg = 0;
if (mv88e6xxx_6352_family(ds) || mv88e6xxx_6351_family(ds) ||
mv88e6xxx_6165_family(ds) || mv88e6xxx_6097_family(ds) ||
- mv88e6xxx_6095_family(ds) || mv88e6xxx_6320_family(ds))
+ mv88e6xxx_6095_family(ds) || mv88e6xxx_6320_family(ds) ||
+ mv88e6xxx_6185_family(ds))
reg = PORT_CONTROL_2_MAP_DA;

if (mv88e6xxx_6352_family(ds) || mv88e6xxx_6351_family(ds) ||
--
2.7.4


2016-03-25 17:20:37

by Vivien Didelot

[permalink] [raw]
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging

Hi,

Vivien Didelot <[email protected]> writes:

> The 88E6185 switch also has a MapDA bit in its Port Control 2 register.
> When this bit is cleared, all frames are sent out to the CPU port.
>
> Set this bit to rely on ATU hits and direct the frame out of the correct
> ports, and thus enable hardware bridging.
>
> Signed-off-by: Vivien Didelot <[email protected]>

Andrew, I sent this patch too fast. It requires a proper support of the
ATU in order to populate the FDB correctly. I send that soon.

David, please ignore this patch for the moment.

Thanks,
Vivien

2016-03-25 19:01:26

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging

From: Vivien Didelot <[email protected]>
Date: Fri, 25 Mar 2016 13:20:30 -0400

> David, please ignore this patch for the moment.

Ok.