2016-04-04 10:14:23

by Luis de Bethencourt

[permalink] [raw]
Subject: [PATCH] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name.

Signed-off-by: Luis de Bethencourt <[email protected]>
---

Hi,

I noticed this typo while fixing bug 114281 [0]. If this type of fixes are
not welcomed I could squash it into the patch for that bug.

Thanks,
Luis

[0] https://bugzilla.kernel.org/show_bug.cgi?id=114281

fs/btrfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index a8e049a..86364b7 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -2028,7 +2028,7 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf)
u64 thresh = 0;

/*
- * holding chunk_muext to avoid allocating new chunks, holding
+ * holding chunk_mutex to avoid allocating new chunks, holding
* device_list_mutex to avoid the device being removed
*/
rcu_read_lock();
--
2.6.4


2016-04-04 11:30:54

by David Sterba

[permalink] [raw]
Subject: Re: [PATCH] btrfs: fix typo in btrfs_statfs()

On Mon, Apr 04, 2016 at 11:13:57AM +0100, Luis de Bethencourt wrote:
> Correct a typo in the chunk_mutex name.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
>
> Hi,
>
> I noticed this typo while fixing bug 114281 [0]. If this type of fixes are
> not welcomed I could squash it into the patch for that bug.

> - * holding chunk_muext to avoid allocating new chunks, holding
> + * holding chunk_mutex to avoid allocating new chunks, holding

In this case it's a name of a mutex, so this makes sense eg. when one is
grepping for it. I'm not against fixing typos in comments in general,
it's usually better to fix several at once, eg. per file, see
bb7ab3b92e46da06b580c6f83abe7894dc449cca . If you find more, then please
send an updated patch, I'll queue this one into cleanups and can replace
it later.