2016-04-08 18:39:52

by Denys Vlasenko

Subject: [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

This function compiles to 895 bytes of machine code.

Clearly, this isn't a time-critical function.
For one, it has a number of udelay(1) calls.

Signed-off-by: Denys Vlasenko <[email protected]>
CC: David S. Miller <[email protected]>
CC: [email protected]
CC: [email protected]
---
drivers/net/ethernet/jme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 3ddf657..711cb19 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -222,7 +222,7 @@ jme_clear_ghc_reset(struct jme_adapter *jme)
jwrite32f(jme, JME_GHC, jme->reg_ghc);
}

-static inline void
+static void
jme_reset_mac_processor(struct jme_adapter *jme)
{
static const u32 mask[WAKEUP_FRAME_MASK_DWNR] = {0, 0, 0, 0};
--
2.1.0

2016-04-14 02:57:32

by David Miller

Subject: Re: [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

From: Denys Vlasenko <[email protected]>
Date: Fri, 8 Apr 2016 20:39:47 +0200

> This function compiles to 895 bytes of machine code.
>
> Clearly, this isn't a time-critical function.
> For one, it has a number of udelay(1) calls.
>
> Signed-off-by: Denys Vlasenko <[email protected]>

No x.c file should be using inline anyways, applied to net-next,
thanks a lot!