This patch series fixes unnecessarry resource consuming
in khugepaged swapin and introduces a new function to
calculate value of specific vm event.
Ebru Akagunduz (2):
mm, vmstat: calculate particular vm event
mm, thp: avoid unnecessary swapin in khugepaged
include/linux/vmstat.h | 6 ++++++
mm/huge_memory.c | 18 +++++++++++++++---
mm/vmstat.c | 12 ++++++++++++
3 files changed, 33 insertions(+), 3 deletions(-)
--
1.9.1
Currently, vmstat can calculate specific vm event with all_vm_events()
however it calculates all vm events at a time. This patch introduces
a new function to calculate only single event at a time.
Signed-off-by: Ebru Akagunduz <[email protected]>
Suggested-by: Kirill A. Shutemov <[email protected]>
Acked-by: Kirill A. Shutemov <[email protected]>
Reviewed-by: Rik van Riel <[email protected]>
Acked-by: Vlastimil Babka <[email protected]>
Acked-by: Christoph Lameter <[email protected]>
---
Changes in v2:
- this patch newly created in this version
- create sum event function to
calculate particular vm event (Kirill A. Shutemov)
Changes in v3:
- add dummy definition of sum_vm_event
when CONFIG_VM_EVENTS is not set
(Kirill A. Shutemov)
Changes in v4:
- add Suggested-by tag (Vlastimil Babka)
Changes in v5:
- CC'ed Christoph Lameter <[email protected]> (Andrew Morton)
Changes in v6:
- Fix commit log (Christoph Lameter)
include/linux/vmstat.h | 6 ++++++
mm/vmstat.c | 12 ++++++++++++
2 files changed, 18 insertions(+)
diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
index 02fce41..723be2c 100644
--- a/include/linux/vmstat.h
+++ b/include/linux/vmstat.h
@@ -53,6 +53,8 @@ static inline void count_vm_events(enum vm_event_item item, long delta)
extern void all_vm_events(unsigned long *);
+extern unsigned long sum_vm_event(enum vm_event_item item);
+
extern void vm_events_fold_cpu(int cpu);
#else
@@ -73,6 +75,10 @@ static inline void __count_vm_events(enum vm_event_item item, long delta)
static inline void all_vm_events(unsigned long *ret)
{
}
+static inline unsigned long sum_vm_event(enum vm_event_item item)
+{
+ return 0;
+}
static inline void vm_events_fold_cpu(int cpu)
{
}
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 070fd90..d6b6c03 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -34,6 +34,18 @@
DEFINE_PER_CPU(struct vm_event_state, vm_event_states) = {{0}};
EXPORT_PER_CPU_SYMBOL(vm_event_states);
+unsigned long sum_vm_event(enum vm_event_item item)
+{
+ int cpu;
+ unsigned long ret = 0;
+
+ get_online_cpus();
+ for_each_online_cpu(cpu)
+ ret += per_cpu(vm_event_states, cpu).event[item];
+ put_online_cpus();
+ return ret;
+}
+
static void sum_vm_events(unsigned long *ret)
{
int cpu;
--
1.9.1
Currently khugepaged makes swapin readahead to improve
THP collapse rate. This patch checks vm statistics
to avoid workload of swapin, if unnecessary. So that
when system under pressure, khugepaged won't consume
resources to swapin and won't trigger direct reclaim
when swapin readahead.
The patch was tested with a test program that allocates
800MB of memory, writes to it, and then sleeps. The system
was forced to swap out all. Afterwards, the test program
touches the area by writing, it skips a page in each
20 pages of the area. When waiting to swapin readahead
left part of the test, the memory forced to be busy
doing page reclaim. There was enough free memory during
test, khugepaged did not swapin readahead due to business.
Test results:
After swapped out
-------------------------------------------------------------------
| Anonymous | AnonHugePages | Swap | Fraction |
-------------------------------------------------------------------
With patch | 0 kB | 0 kB | 800000 kB | %100 |
-------------------------------------------------------------------
Without patch | 0 kB | 0 kB | 800000 kB | %100 |
-------------------------------------------------------------------
After swapped in
-------------------------------------------------------------------
| Anonymous | AnonHugePages | Swap | Fraction |
-------------------------------------------------------------------
With patch | 385120 kB | 102400 kB | 414880 kB | %26 |
-------------------------------------------------------------------
Without patch | 389728 kB | 194560 kB | 410272 kB | %49 |
-------------------------------------------------------------------
Signed-off-by: Ebru Akagunduz <[email protected]>
Acked-by: Rik van Riel <[email protected]>
---
Changes in v2:
- Add reference to specify which patch fixed (Ebru Akagunduz)
- Fix commit subject line (Ebru Akagunduz)
Changes in v3:
- Remove default values of allocstall (Kirill A. Shutemov)
Changes in v4:
- define unsigned long allocstall instead of unsigned long int
(Vlastimil Babka)
- compare allocstall when khugepaged goes to sleep
(Rik van Riel, Vlastimil Babka)
Changes in v5:
- Drop fixes sha part because fixed patch is not in Linus's tree
(Michal Hocko)
- Save allocstall where khugepaged exactly sleeps (Michal Hocko)
Changes in v6:
- Fix build error (test robot)
Note: I didn't add optimistic swapin and mmap_sem in this
patch series. I couldn't overcome yet.
I'll send them after the series ends up.
mm/huge_memory.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 23740cd..ae99524 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -105,6 +105,7 @@ static DECLARE_WAIT_QUEUE_HEAD(khugepaged_wait);
*/
static unsigned int khugepaged_max_ptes_none __read_mostly;
static unsigned int khugepaged_max_ptes_swap __read_mostly = HPAGE_PMD_NR/8;
+static unsigned long allocstall;
static int khugepaged(void *none);
static int khugepaged_slab_init(void);
@@ -2451,7 +2452,7 @@ static void collapse_huge_page(struct mm_struct *mm,
struct page *new_page;
spinlock_t *pmd_ptl, *pte_ptl;
int isolated = 0, result = 0;
- unsigned long hstart, hend;
+ unsigned long hstart, hend, swap, curr_allocstall;
struct mem_cgroup *memcg;
unsigned long mmun_start; /* For mmu_notifiers */
unsigned long mmun_end; /* For mmu_notifiers */
@@ -2506,7 +2507,14 @@ static void collapse_huge_page(struct mm_struct *mm,
goto out;
}
- __collapse_huge_page_swapin(mm, vma, address, pmd);
+ swap = get_mm_counter(mm, MM_SWAPENTS);
+ curr_allocstall = sum_vm_event(ALLOCSTALL);
+ /*
+ * When system under pressure, don't swapin readahead.
+ * So that avoid unnecessary resource consuming.
+ */
+ if (allocstall == curr_allocstall && swap != 0)
+ __collapse_huge_page_swapin(mm, vma, address, pmd);
anon_vma_lock_write(vma->anon_vma);
@@ -2900,14 +2908,17 @@ static void khugepaged_wait_work(void)
if (!khugepaged_scan_sleep_millisecs)
return;
+ allocstall = sum_vm_event(ALLOCSTALL);
wait_event_freezable_timeout(khugepaged_wait,
kthread_should_stop(),
msecs_to_jiffies(khugepaged_scan_sleep_millisecs));
return;
}
- if (khugepaged_enabled())
+ if (khugepaged_enabled()) {
+ allocstall = sum_vm_event(ALLOCSTALL);
wait_event_freezable(khugepaged_wait, khugepaged_wait_event());
+ }
}
static int khugepaged(void *none)
@@ -2916,6 +2927,7 @@ static int khugepaged(void *none)
set_freezable();
set_user_nice(current, MAX_NICE);
+ allocstall = sum_vm_event(ALLOCSTALL);
while (!kthread_should_stop()) {
khugepaged_do_scan();
--
1.9.1