by Guodong Xu

[permalink] [raw]

Subject: Re: [PATCH v4 14/16] arm64: dts: hikey: Add hi655x pmic dts node

On 13 April 2016 at 08:11, Rob Herring <[email protected]> wrote:
> On Tue, Apr 12, 2016 at 6:55 PM, Guodong Xu <[email protected]> wrote:
>> From: Chen Feng <[email protected]>
>>
>> Add the mfd hi655x dts node and regulator support on hi6220 platform.
>>
>> Signed-off-by: Chen Feng <[email protected]>
>> Signed-off-by: Fei Wang <[email protected]>
>> Signed-off-by: Xinwei Kong <[email protected]>
>> Signed-off-by: Guodong Xu <[email protected]>
>> Reviewed-by: Haojian Zhuang <[email protected]>
>> Reviewed-by: Rob Herring <[email protected]>
>
> I did not provide a Reviewed-by. You cannot add people's Reviewed-by
> just because they provided a review. It is only when the review is
> finished that the reviewer will give it.

Got it.
:)

>
> That being said, it looks fine now and you can add it.

Thank you.

-Guodong

>
>> Acked-by: Lee Jones <[email protected]>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 87 +++++++++++++++++++++++++-
>> 1 file changed, 86 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index b7c41f8..cc1148d 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -6,9 +6,9 @@
>> */
>>
>> /dts-v1/;
>> -
>> #include "hi6220.dtsi"
>> #include "hikey-pinctrl.dtsi"
>> +#include <dt-bindings/gpio/gpio.h>
>>
>> / {
>> model = "HiKey Development Board";
>> @@ -107,6 +107,91 @@
>> default-state = "off";
>> };
>> };
>> +
>> + pmic: pmic@f8000000 {
>> + compatible = "hisilicon,hi655x-pmic";
>> + reg = <0x0 0xf8000000 0x0 0x1000>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>> +
>> + regulators {
>> + ldo2: LDO2 {
>> + regulator-name = "LDO2_2V8";
>> + regulator-min-microvolt = <2500000>;
>> + regulator-max-microvolt = <3200000>;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo7: LDO7 {
>> + regulator-name = "LDO7_SDIO";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo10: LDO10 {
>> + regulator-name = "LDO10_2V85";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-enable-ramp-delay = <360>;
>> + };
>> +
>> + ldo13: LDO13 {
>> + regulator-name = "LDO13_1V8";
>> + regulator-min-microvolt = <1600000>;
>> + regulator-max-microvolt = <1950000>;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo14: LDO14 {
>> + regulator-name = "LDO14_2V8";
>> + regulator-min-microvolt = <2500000>;
>> + regulator-max-microvolt = <3200000>;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo15: LDO15 {
>> + regulator-name = "LDO15_1V8";
>> + regulator-min-microvolt = <1600000>;
>> + regulator-max-microvolt = <1950000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo17: LDO17 {
>> + regulator-name = "LDO17_2V5";
>> + regulator-min-microvolt = <2500000>;
>> + regulator-max-microvolt = <3200000>;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo19: LDO19 {
>> + regulator-name = "LDO19_3V0";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-enable-ramp-delay = <360>;
>> + };
>> +
>> + ldo21: LDO21 {
>> + regulator-name = "LDO21_1V8";
>> + regulator-min-microvolt = <1650000>;
>> + regulator-max-microvolt = <2000000>;
>> + regulator-always-on;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> +
>> + ldo22: LDO22 {
>> + regulator-name = "LDO22_1V2";
>> + regulator-min-microvolt = <900000>;
>> + regulator-max-microvolt = <1200000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-enable-ramp-delay = <120>;
>> + };
>> + };
>> + };
>> };
>>
>> &uart2 {
>> --
>> 1.9.1
>>

2016-04-16 16:57:59

by Wei Xu

[permalink] [raw]

Subject: Re: [PATCH v4 00/16] DTS for hi6220 and HiKey

Hi Guodong,

On 13/04/2016 00:55, Guodong Xu wrote:
> This patchset include dts changes for hi6220 SoC and HiKey board. These
> patches apply well one by one on top of next-20160401. All tested on HiKey
> and pass.
>
> To avoid merge conflicts with patches already ack'ed by maintainers,
> I picked all hi6220/hikey dts related patches into this single patchset.
> And they passed the tests on HiKey.
>
> Patch 1~3 are from hi6220 cpuidle support. It has been reviewed and
> ack'ed in maillist.
> [PATCH v2 RESEND 0/4] arm64: Hi6220: enable CPU idle states:
> http://archive.arm.linux.org.uk/lurker/message/20160121.105346.7d3b0470.en.html
>
> Patch 4 is for hi6220 gpio.
>
> Patch 5 is for pinctl.
> Acked-by: Linus Walleij <[email protected]>
> Acked-by: Haojian Zhuang <[email protected]>
>
> Patch 6 is for spi configuration.
>
> Patch 7 adds hi6220 i2c nodes, and
> patch 8 enables them for hikey board usage.
>
> Patch 9 adds add hi6220 usb node. It has been sent to maillist.
> [PATCH] arm64: dts: add hi6220 usb node
> http://thread.gmane.org/gmane.linux.drivers.devicetree/146062
> http://thread.gmane.org/gmane.linux.drivers.devicetree/144335/focus=134022
> Acked-by: Rob Herring <[email protected]>
>
> Patch 10 and 11 are from hi6220 mailbox support. It has been reviewed and
> ack'ed in maillist.
> [PATCH v7 RESEND 0/4] mailbox: hisilicon: add Hi6220 mailbox driver
> http://thread.gmane.org/gmane.linux.kernel/2152759/focus=2152768
> Acked-by: Jassi Brar <[email protected]>
> Acked-by: Wei Xu <[email protected]>
> Patch 13 adds gpio LEDs device nodes.
>
> Patch 14 adds hi655x pmic dts node and regulator support.
> [PATCH v8 5/5] arm64: dts: hisilicon: Add hi655x pmic dts node
> http://thread.gmane.org/gmane.linux.kernel/2151688
> Acked-by: Lee Jones <[email protected]>
>
> Patch 15 adds dwmmc nodes description for hi6220. It refers to two LDO's
> which are defined above.
> Patch 16 adds wifi device node (TI's wl1835) for HiKey board.

Series applied to the Hisilicon soc tree, thanks!

Best Regards,
Wei

>
> v4:
> - remove hikey-gpio.dtsi
> - disable spi0 by default and let boards override it
> - remove LDOs unit address
> - fix style problems after review
>
> v3:
> - update patch 2 sp804 clocks and clock-names
> - add Acked-by into commits where applies.
>
> v2:
> - picked hi655x pmic dts node.
> - removed dw_mmc resets property, as it is still under review.
> - add 'non-removable' into dw_mmc2 for wifi
>
> Chen Feng (1):
> arm64: dts: hikey: Add hi655x pmic dts node
>
> Guodong Xu (4):
> arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine
> boards
> arm64: dts: hi6220: add pinctrl for uarts and enable them
> arm64: dts: add LED nodes for hi6220-hikey
> arm64: dts: add wifi nodes support for hi6220-hikey
>
> Leo Yan (5):
> arm64: dts: Reserve memory regions for hi6220
> arm64: dts: add sp804 timer node for Hi6220
> arm64: dts: enable idle states for Hi6220
> arm64: dts: add mailbox node for Hi6220
> arm64: dts: add Hi6220's stub clock node
>
> Xinwei Kong (2):
> arm64: dts: add all hi6220 i2c nodes
> arm64: dts: add dwmmc nodes for hi6220
>
> Zhangfei Gao (1):
> arm64: dts: Add hi6220 usb node
>
> Zhong Kaihua (3):
> arm64: dts: Add Hi6220 gpio configuration nodes
> arm64: dts: add Hi6220 pinctrl configuration nodes
> arm64: dts: add Hi6220 spi configuration nodes
>
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 200 ++++++-
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 563 ++++++++++++++++++
> arch/arm64/boot/dts/hisilicon/hikey-pinctrl.dtsi | 705 +++++++++++++++++++++++
> include/dt-bindings/pinctrl/hisi.h | 59 ++
> 4 files changed, 1522 insertions(+), 5 deletions(-)
> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-pinctrl.dtsi
> create mode 100644 include/dt-bindings/pinctrl/hisi.h
>