2016-04-20 01:40:09

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH] ARM: mv78xx0: Remove CLK_IS_ROOT

This flag is a no-op now (see commit 47b0eeb3dc8a "clk: Deprecate
CLK_IS_ROOT", 2016-02-02) so remove it.

Cc: Andrew Lunn <[email protected]>
Cc: Jason Cooper <[email protected]
Signed-off-by: Stephen Boyd <[email protected]>
---
arch/arm/mach-mv78xx0/common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-mv78xx0/common.c b/arch/arm/mach-mv78xx0/common.c
index 99cc93900a24..45a05207b418 100644
--- a/arch/arm/mach-mv78xx0/common.c
+++ b/arch/arm/mach-mv78xx0/common.c
@@ -168,8 +168,7 @@ static struct clk *tclk;

static void __init clk_init(void)
{
- tclk = clk_register_fixed_rate(NULL, "tclk", NULL, CLK_IS_ROOT,
- get_tclk());
+ tclk = clk_register_fixed_rate(NULL, "tclk", NULL, 0, get_tclk());

orion_clkdev_init(tclk);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2016-04-20 07:36:07

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] ARM: mv78xx0: Remove CLK_IS_ROOT

On Tuesday 19 April 2016 18:40:04 Stephen Boyd wrote:
> This flag is a no-op now (see commit 47b0eeb3dc8a "clk: Deprecate
> CLK_IS_ROOT", 2016-02-02) so remove it.
>
> Cc: Andrew Lunn <[email protected]>
> Cc: Jason Cooper <[email protected]
> Signed-off-by: Stephen Boyd <[email protected]>
>

Looks good, like all other instances in arch/arm.

If you want to merge these through your tree, please add my

Acked-by: Arnd Bergmann <[email protected]>

to all of them, in addition to the other other Acks. I don't
think there is a significant risk for regressions as they all
tend to be "stable" in the sense that those files haven't
been touched in a while.

Arnd

2016-04-20 18:40:10

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] ARM: mv78xx0: Remove CLK_IS_ROOT

On 04/20, Arnd Bergmann wrote:
> On Tuesday 19 April 2016 18:40:04 Stephen Boyd wrote:
> > This flag is a no-op now (see commit 47b0eeb3dc8a "clk: Deprecate
> > CLK_IS_ROOT", 2016-02-02) so remove it.
> >
> > Cc: Andrew Lunn <[email protected]>
> > Cc: Jason Cooper <[email protected]
> > Signed-off-by: Stephen Boyd <[email protected]>
> >
>
> Looks good, like all other instances in arch/arm.
>
> If you want to merge these through your tree, please add my
>
> Acked-by: Arnd Bergmann <[email protected]>
>
> to all of them, in addition to the other other Acks. I don't
> think there is a significant risk for regressions as they all
> tend to be "stable" in the sense that those files haven't
> been touched in a while.
>

Thanks. If Gregory doesn't pick them up I'll take care of it, but
we're not in any hurry here.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2016-04-27 11:05:52

by Gregory CLEMENT

[permalink] [raw]
Subject: Re: [PATCH] ARM: mv78xx0: Remove CLK_IS_ROOT

Hi Stephen,

On mer., avril 20 2016, Stephen Boyd <[email protected]> wrote:

> This flag is a no-op now (see commit 47b0eeb3dc8a "clk: Deprecate
> CLK_IS_ROOT", 2016-02-02) so remove it.
>
> Cc: Andrew Lunn <[email protected]>
> Cc: Jason Cooper <[email protected]
> Signed-off-by: Stephen Boyd <[email protected]>

Applied on mvebu/soc

(I fixed the email format for Jason: the closing angle bracket was
missing)

Thanks,

Gregory
> ---
> arch/arm/mach-mv78xx0/common.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mv78xx0/common.c b/arch/arm/mach-mv78xx0/common.c
> index 99cc93900a24..45a05207b418 100644
> --- a/arch/arm/mach-mv78xx0/common.c
> +++ b/arch/arm/mach-mv78xx0/common.c
> @@ -168,8 +168,7 @@ static struct clk *tclk;
>
> static void __init clk_init(void)
> {
> - tclk = clk_register_fixed_rate(NULL, "tclk", NULL, CLK_IS_ROOT,
> - get_tclk());
> + tclk = clk_register_fixed_rate(NULL, "tclk", NULL, 0, get_tclk());
>
> orion_clkdev_init(tclk);
> }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com