2016-04-26 06:55:08

by Shawn Lin

Subject: [PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities

Add MMC_CAP_CMD23 for dw_mmc-rockchip, otherwise
failing to create rpmb partition. With it, we can
get rpmb successfully:

mmc1: new HS200 MMC card at address 0001
mmcblk0: mmc1:0001 DS2016 14.7 GiB
mmcblk0boot0: mmc1:0001 DS2016 partition 1 4.00 MiB
mmcblk0boot1: mmc1:0001 DS2016 partition 2 4.00 MiB
mmcblk0rpmb: mmc1:0001 DS2016 partition 3 4.00 MiB

Signed-off-by: Shawn Lin <[email protected]>
---

drivers/mmc/host/dw_mmc-rockchip.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index 8c20b81..2b4bcd2 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -233,10 +233,10 @@ static int dw_mci_rockchip_init(struct dw_mci *host)

/* Common capabilities of RK3288 SoC */
static unsigned long dw_mci_rk3288_dwmmc_caps[4] = {
- MMC_CAP_ERASE,
- MMC_CAP_ERASE,
- MMC_CAP_ERASE,
- MMC_CAP_ERASE,
+ MMC_CAP_ERASE | MMC_CAP_CMD23,
+ MMC_CAP_ERASE | MMC_CAP_CMD23,
+ MMC_CAP_ERASE | MMC_CAP_CMD23,
+ MMC_CAP_ERASE | MMC_CAP_CMD23,
};

static const struct dw_mci_drv_data rk2928_drv_data = {
--
2.3.7

2016-04-27 08:36:17

by Jaehoon Chung

Subject: Re: [PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities

Hi Shawn,

I will apply this. Thanks!

Best Regards,
Jaehoon Chung

On 04/26/2016 03:53 PM, Shawn Lin wrote:
> Add MMC_CAP_CMD23 for dw_mmc-rockchip, otherwise
> failing to create rpmb partition. With it, we can
> get rpmb successfully:
>
> mmc1: new HS200 MMC card at address 0001
> mmcblk0: mmc1:0001 DS2016 14.7 GiB
> mmcblk0boot0: mmc1:0001 DS2016 partition 1 4.00 MiB
> mmcblk0boot1: mmc1:0001 DS2016 partition 2 4.00 MiB
> mmcblk0rpmb: mmc1:0001 DS2016 partition 3 4.00 MiB
>
> Signed-off-by: Shawn Lin <[email protected]>
> ---
>
> drivers/mmc/host/dw_mmc-rockchip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 8c20b81..2b4bcd2 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -233,10 +233,10 @@ static int dw_mci_rockchip_init(struct dw_mci *host)
>
> /* Common capabilities of RK3288 SoC */
> static unsigned long dw_mci_rk3288_dwmmc_caps[4] = {
> - MMC_CAP_ERASE,
> - MMC_CAP_ERASE,
> - MMC_CAP_ERASE,
> - MMC_CAP_ERASE,
> + MMC_CAP_ERASE | MMC_CAP_CMD23,
> + MMC_CAP_ERASE | MMC_CAP_CMD23,
> + MMC_CAP_ERASE | MMC_CAP_CMD23,
> + MMC_CAP_ERASE | MMC_CAP_CMD23,
> };
>
> static const struct dw_mci_drv_data rk2928_drv_data = {
>