2016-04-28 16:32:42

by Vaishali Thakkar

[permalink] [raw]
Subject: [PATCH] [SCSI] csiostor: Do not use sizeof on pointer type

When sizeof is applied to a pointer typed expression, it gives
the size of the pointer. So, here do not use sizeof on pointer
type.

Problem found using Coccinelle.

Fixes: a3667aaed569 ('[SCSI] csiostor: Chelsio FCoE offload driver')

Signed-off-by: Vaishali Thakkar <[email protected]>
---
drivers/scsi/csiostor/csio_mb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/csiostor/csio_mb.c b/drivers/scsi/csiostor/csio_mb.c
index 9451787..a736de0 100644
--- a/drivers/scsi/csiostor/csio_mb.c
+++ b/drivers/scsi/csiostor/csio_mb.c
@@ -1534,7 +1534,7 @@ csio_mb_isr_handler(struct csio_hw *hw)
* Enqueue event to EventQ. Events processing happens
* in Event worker thread context
*/
- if (csio_enqueue_evt(hw, CSIO_EVT_MBX, mbp, sizeof(mbp)))
+ if (csio_enqueue_evt(hw, CSIO_EVT_MBX, mbp, sizeof(*mbp)))
CSIO_INC_STATS(hw, n_evt_drop);

return 0;
--
2.1.4