2016-10-01 09:41:06

by Ksenija Stanojevic

Subject: [PATCH] Staging: fbtft: Fix bug in fbtft-core

Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug
in fbtft-core where fps is always 0, this is because variable
update_time is not assigned correctly.

Signed-off-by: Ksenija Stanojevic <[email protected]>
---
drivers/staging/fbtft/fbtft-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index d9046162..587f68a 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -391,11 +391,11 @@ static void fbtft_update_display(struct fbtft_par *par, unsigned int start_line,

if (unlikely(timeit)) {
ts_end = ktime_get();
- if (ktime_to_ns(par->update_time))
+ if (!ktime_to_ns(par->update_time))
par->update_time = ts_start;

- par->update_time = ts_start;
fps = ktime_us_delta(ts_start, par->update_time);
+ par->update_time = ts_start;
fps = fps ? 1000000 / fps : 0;

throughput = ktime_us_delta(ts_end, ts_start);
--
1.9.1

2016-10-02 15:16:54

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: fbtft: Fix bug in fbtft-core

On Sat, Oct 01, 2016 at 11:40:52AM +0200, Ksenija Stanojevic wrote:
> Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug
> in fbtft-core where fps is always 0, this is because variable
> update_time is not assigned correctly.
>
> Signed-off-by: Ksenija Stanojevic <[email protected]>

Can you add a "Fixes:" tag here, showing the short sha1 id and name of
the patch this is fixing, and add a cc: stable line as well? That way
we can know to backport this to the relevant kernels (4.4 and newer).

thanks,

greg k-h