2016-10-17 15:11:05

by Frank Rowand

[permalink] [raw]
Subject: [PATCH] Add missing space at end of pr_fmt().

From: Frank Rowand <[email protected]>

Make pr_fmt() in fdt.c consistent with all other files in drivers/of/

Signed-off-by: Frank Rowand <[email protected]>
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index c89d5d231a0e..9f98e437e1f1 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -9,7 +9,7 @@
* version 2 as published by the Free Software Foundation.
*/

-#define pr_fmt(fmt) "OF: fdt:" fmt
+#define pr_fmt(fmt) "OF: fdt: " fmt

#include <linux/crc32.h>
#include <linux/kernel.h>
--
1.9.1


2016-10-17 17:07:41

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] Add missing space at end of pr_fmt().

On Mon, 2016-10-17 at 08:10 -0700, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> Make pr_fmt() in fdt.c consistent with all other files in drivers/of/

Hi Frank.

Patches should use the subsystem as a subject prefix to make
the subsystem more obvious when using "git log".

This email subject could be something like:

"Subject: [PATCH] of: fdt: Add missing space at end of pr_fmt()"

Please check the git log to see examples for drivers/of/fdt.c
and pick the prefix style you think appropriate.

> Signed-off-by: Frank Rowand <[email protected]>
> ---
> drivers/of/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index c89d5d231a0e..9f98e437e1f1 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -9,7 +9,7 @@
> * version 2 as published by the Free Software Foundation.
> */
>
> -#define pr_fmt(fmt) "OF: fdt:" fmt
> +#define pr_fmt(fmt) "OF: fdt: " fmt
>
> #include <linux/crc32.h>
> #include <linux/kernel.h>
>

2016-10-17 19:09:35

by Frank Rowand

[permalink] [raw]
Subject: Re: [PATCH] Add missing space at end of pr_fmt().

On 10/17/16 08:10, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> Make pr_fmt() in fdt.c consistent with all other files in drivers/of/
>
> Signed-off-by: Frank Rowand <[email protected]>

Rob,

Please ignore due to bad subject (as noted by Joe). I will resend
with proper subject.

-Frank