2016-10-26 11:13:23

by Kirill Esipov

Subject: [PATCH] usb: musb: remove duplicated actions

Remove unnecessary duplicate actions (that we've got here:
19915e623458004547c1c2490b09bb923fe69337)

Signed-off-by: Kirill Esipov <[email protected]>
---
drivers/usb/musb/musb_core.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 27dadc0..2b04f07 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2120,12 +2120,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
if (musb->ops->ep_select)
musb->io.ep_select = musb->ops->ep_select;

- /* At least tusb6010 has its own offsets */
- if (musb->ops->ep_offset)
- musb->io.ep_offset = musb->ops->ep_offset;
- if (musb->ops->ep_select)
- musb->io.ep_select = musb->ops->ep_select;
-
if (musb->ops->fifo_mode)
fifo_mode = musb->ops->fifo_mode;
else
--
2.7.4

2016-10-26 11:16:47

by Sergei Shtylyov

Subject: Re: [PATCH] usb: musb: remove duplicated actions

Hello.

On 10/26/2016 2:12 PM, Kirill Esipov wrote:

> Remove unnecessary duplicate actions (that we've got here:
> 19915e623458004547c1c2490b09bb923fe69337)

You should also specify the commit's summary line in (""). And it's enough
to specify 12 digits of SHA1 ID.

> Signed-off-by: Kirill Esipov <[email protected]>
[...]

MBR, Sergei