2016-10-26 17:05:18

by Marcelo Henrique Cerri

Subject: [PATCH 0/3] crypto: testmgr - Add missing tests for internal sha*-mb implementations

This series adds null tests for all sha*-mb internal algorithms so they can
be used in FIPS mode without further problems.

Since they are 3 separated modules I decided to use a separated commit for
each one.

Marcelo Cerri (3):
crypto: testmgr - Add missing tests for internal sha1-mb
implementation
crypto: testmgr - Add missing tests for internal sha256-mb
implementation
crypto: testmgr - Add missing tests for internal sha512-mb
implementation

crypto/testmgr.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

--
2.7.4

2016-10-26 17:05:29

by Marcelo Henrique Cerri

Subject: [PATCH 1/3] crypto: testmgr - Add missing tests for internal sha1-mb implementation

Add null tests for the internal algorithm to avoid errors when running
in FIPS mode.

Signed-off-by: Marcelo Cerri <[email protected]>
---
crypto/testmgr.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index ded50b6..d999373 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2305,6 +2305,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.test = alg_test_null,
.fips_allowed = 1,
}, {
+ .alg = "__intel_sha1-mb",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "ansi_cprng",
.test = alg_test_cprng,
.suite = {
@@ -3750,6 +3754,10 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
+ .alg = "mcryptd(__intel_sha1-mb)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "md4",
.test = alg_test_hash,
.suite = {
--
2.7.4

2016-10-26 17:05:42

by Marcelo Henrique Cerri

Subject: [PATCH 3/3] crypto: testmgr - Add missing tests for internal sha512-mb implementation

Add null tests for the internal algorithm to avoid errors when running
in FIPS mode.

Signed-off-by: Marcelo Cerri <[email protected]>
---
crypto/testmgr.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 58f903d..cfafd24 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2313,6 +2313,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.test = alg_test_null,
.fips_allowed = 1,
}, {
+ .alg = "__intel_sha512-mb",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "ansi_cprng",
.test = alg_test_cprng,
.suite = {
@@ -3766,6 +3770,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.test = alg_test_null,
.fips_allowed = 1,
}, {
+ .alg = "mcryptd(__intel_sha512-mb)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "md4",
.test = alg_test_hash,
.suite = {
--
2.7.4

2016-10-26 17:05:57

by Marcelo Henrique Cerri

Subject: [PATCH 2/3] crypto: testmgr - Add missing tests for internal sha256-mb implementation

Add null tests for the internal algorithm to avoid errors when running
in FIPS mode.

Signed-off-by: Marcelo Cerri <[email protected]>
---
crypto/testmgr.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index d999373..58f903d 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2309,6 +2309,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.test = alg_test_null,
.fips_allowed = 1,
}, {
+ .alg = "__intel_sha256-mb",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "ansi_cprng",
.test = alg_test_cprng,
.suite = {
@@ -3758,6 +3762,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.test = alg_test_null,
.fips_allowed = 1,
}, {
+ .alg = "mcryptd(__intel_sha256-mb)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "md4",
.test = alg_test_hash,
.suite = {
--
2.7.4

2016-11-01 00:33:00

by Herbert Xu

Subject: Re: [PATCH 0/3] crypto: testmgr - Add missing tests for internal sha*-mb implementations

On Wed, Oct 26, 2016 at 03:04:42PM -0200, Marcelo Cerri wrote:
> This series adds null tests for all sha*-mb internal algorithms so they can
> be used in FIPS mode without further problems.
>
> Since they are 3 separated modules I decided to use a separated commit for
> each one.
>
> Marcelo Cerri (3):
> crypto: testmgr - Add missing tests for internal sha1-mb
> implementation
> crypto: testmgr - Add missing tests for internal sha256-mb
> implementation
> crypto: testmgr - Add missing tests for internal sha512-mb
> implementation
>
> crypto/testmgr.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)

I have a patch pending that skips testing of all internal algorithms.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt