2016-10-20 12:22:26

by Jani Nikula

[permalink] [raw]
Subject: [PATCH 1/4] MAINTAINERS: Add "B:" for URI where to file bugs

Different subsystems and drivers have different preferences for where to
file bugs and what information to include. Add "B:" entry for specifying
the URI for the bug tracker directly, a web page for detailed info on
filing bugs, or a mailto: URI.

Cc: Daniel Vetter <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Jani Nikula <[email protected]>

---

Dust settled since the last time, maybe we can make URI work?
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 89112a65b831..4a47ec00a09d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -74,6 +74,8 @@ Descriptions of section entries:
These reviewers should be CCed on patches.
L: Mailing list that is relevant to this area
W: Web-page with status/info
+ B: URI for where to file bugs. A web-page with detailed bug
+ filing info, a direct bug tracker link, or a mailto: URI.
Q: Patchwork web based patch tracking system site
T: SCM tree type and location.
Type is one of: git, hg, quilt, stgit, topgit
--
2.1.4


2016-10-20 12:22:30

by Jani Nikula

[permalink] [raw]
Subject: [PATCH 3/4] MAINTAINERS: Add "C:" for URI for chat where developers hang out

Make it easier to find the developer chat for the subsystem or driver.

Signed-off-by: Jani Nikula <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 689f7f08a100..53df9ccc5573 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -76,6 +76,8 @@ Descriptions of section entries:
W: Web-page with status/info
B: URI for where to file bugs. A web-page with detailed bug
filing info, a direct bug tracker link, or a mailto: URI.
+ C: URI for chat protocol, server and channel where developers
+ usually hang out, for example irc://server/channel.
Q: Patchwork web based patch tracking system site
T: SCM tree type and location.
Type is one of: git, hg, quilt, stgit, topgit
--
2.1.4

2016-10-20 12:22:35

by Jani Nikula

[permalink] [raw]
Subject: [PATCH 4/4] MAINTAINERS: add drm and drm/i915 irc channels

Signed-off-by: Jani Nikula <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 53df9ccc5573..a6bde481170c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3954,6 +3954,7 @@ M: David Airlie <[email protected]>
L: [email protected]
T: git git://people.freedesktop.org/~airlied/linux
B: https://bugs.freedesktop.org/
+C: irc://chat.freenode.net/dri-devel
S: Maintained
F: drivers/gpu/drm/
F: drivers/gpu/vga/
@@ -4007,6 +4008,7 @@ L: [email protected]
L: [email protected]
W: https://01.org/linuxgraphics/
B: https://01.org/linuxgraphics/documentation/how-report-bugs
+C: irc://chat.freenode.net/intel-gfx
Q: http://patchwork.freedesktop.org/project/intel-gfx/
T: git git://anongit.freedesktop.org/drm-intel
S: Supported
--
2.1.4

2016-10-20 12:23:00

by Jani Nikula

[permalink] [raw]
Subject: [PATCH 2/4] MAINTAINERS: add drm and drm/i915 bug filing info

Signed-off-by: Jani Nikula <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4a47ec00a09d..689f7f08a100 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3951,6 +3951,7 @@ DRM DRIVERS
M: David Airlie <[email protected]>
L: [email protected]
T: git git://people.freedesktop.org/~airlied/linux
+B: https://bugs.freedesktop.org/
S: Maintained
F: drivers/gpu/drm/
F: drivers/gpu/vga/
@@ -4003,6 +4004,7 @@ M: Jani Nikula <[email protected]>
L: [email protected]
L: [email protected]
W: https://01.org/linuxgraphics/
+B: https://01.org/linuxgraphics/documentation/how-report-bugs
Q: http://patchwork.freedesktop.org/project/intel-gfx/
T: git git://anongit.freedesktop.org/drm-intel
S: Supported
--
2.1.4

2016-10-24 08:31:36

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH 1/4] MAINTAINERS: Add "B:" for URI where to file bugs

On Thu, Oct 20, 2016 at 03:22:12PM +0300, Jani Nikula wrote:
> Different subsystems and drivers have different preferences for where to
> file bugs and what information to include. Add "B:" entry for specifying
> the URI for the bug tracker directly, a web page for detailed info on
> filing bugs, or a mailto: URI.
>
> Cc: Daniel Vetter <[email protected]>
> Cc: Joe Perches <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Jani Nikula <[email protected]>
>
> ---
>
> Dust settled since the last time, maybe we can make URI work?

fwiw I want this, I think documenting bugzilla and irc channels (for
subsystems and drivers using them) will help a lot to make
(sub)communities of the kernel more approachable. On the entire series:

Very-much-Wanted-by: Daniel Vetter <[email protected]>

> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 89112a65b831..4a47ec00a09d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -74,6 +74,8 @@ Descriptions of section entries:
> These reviewers should be CCed on patches.
> L: Mailing list that is relevant to this area
> W: Web-page with status/info
> + B: URI for where to file bugs. A web-page with detailed bug
> + filing info, a direct bug tracker link, or a mailto: URI.
> Q: Patchwork web based patch tracking system site
> T: SCM tree type and location.
> Type is one of: git, hg, quilt, stgit, topgit
> --
> 2.1.4
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2016-10-24 08:48:21

by Andrew Donnellan

[permalink] [raw]
Subject: Re: [PATCH 1/4] MAINTAINERS: Add "B:" for URI where to file bugs

On 20/10/16 23:22, Jani Nikula wrote:
> Different subsystems and drivers have different preferences for where to
> file bugs and what information to include. Add "B:" entry for specifying
> the URI for the bug tracker directly, a web page for detailed info on
> filing bugs, or a mailto: URI.
>
> Cc: Daniel Vetter <[email protected]>
> Cc: Joe Perches <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Jani Nikula <[email protected]>

Both new fields seem like a very, very good idea to me. It'll definitely
save me a bit of googling and wiki-searching on the rare occasion I
venture outside powerpc...

For the whole series:

Reviewed-by: Andrew Donnellan <[email protected]>

--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited

2016-10-24 18:14:15

by Joe Perches

[permalink] [raw]
Subject: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

Jani Nikula proposes patches to add a few new letter prefixes
for "B:" bug reporting and "C:" maintainer chatting to the
various sections of MAINTAINERS.

Add a generic mechanism to get_maintainer.pl to find sections that
have any combination of "[A-Z]" letter prefix types in a section.

Signed-off-by: Joe Perches <[email protected]>
---
?scripts/get_maintainer.pl | 12 +++++++++---
?1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index aed4511f0304..633f2dd3de27 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -49,6 +49,7 @@ my $scm = 0;
?my $web = 0;
?my $subsystem = 0;
?my $status = 0;
+my $letters = "";
?my $keywords = 1;
?my $sections = 0;
?my $file_emails = 0;
@@ -241,6 +242,7 @@ if (!GetOptions(
? 'status!' => \$status,
? 'scm!' => \$scm,
? 'web!' => \$web,
+ 'letters=s' => \$letters,
? 'pattern-depth=i' => \$pattern_depth,
? 'k|keywords!' => \$keywords,
? 'sections!' => \$sections,
@@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", ");
?$output_rolestats = 1 if ($interactive);
?$output_roles = 1 if ($output_rolestats);
?
-if ($sections) {
+if ($sections || $letters ne "") {
+????$sections = 1;
?????$email = 0;
?????$email_list = 0;
?????$scm = 0;
@@ -682,8 +685,10 @@ sub get_maintainers {
? $line =~ s/\\\./\./g;??????? ##Convert \. to .
? $line =~ s/\.\*/\*/g;??????? ##Convert .* to *
? ????}
- ????$line =~ s/^([A-Z]):/$1:\t/g;
- ????print("$line\n");
+ ????my $count = $line =~ s/^([A-Z]):/$1:\t/g;
+ ????if ($letters eq "" || (!$count || $letters =~ /$1/i)) {
+ print("$line\n");
+ ????}
? }
? print("\n");
? ????}
@@ -814,6 +819,7 @@ Other options:
???--pattern-depth => Number of pattern directory traversals (default: 0 (all))
???--keywords => scan patch for keywords (default: $keywords)
???--sections => print all of the subsystem sections with pattern matches
+??--letters => print all matching 'letter' types from all matching sections
???--mailmap => use .mailmap file (default: $email_use_mailmap)
???--version => show version
???--help => show this help information

2016-11-03 09:07:34

by Paul Bolle

[permalink] [raw]
Subject: Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

On Mon, 2016-10-24 at 11:05 -0700, Joe Perches wrote:
> Jani Nikula proposes patches to add a few new letter prefixes
> for "B:" bug reporting and "C:" maintainer chatting to the
> various sections of MAINTAINERS.
>
> Add a generic mechanism to get_maintainer.pl to find sections that
> have any combination of "[A-Z]" letter prefix types in a section.
>
> Signed-off-by: Joe Perches <[email protected]>

This patch made it into linux-next (ie, next-20161028).

> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl

> @@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", ");
>  $output_rolestats = 1 if ($interactive);
>  $output_roles = 1 if ($output_rolestats);
>  
> -if ($sections) {
> +if ($sections || $letters ne "") {
> +    $sections = 1;

This triggers:
    Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at ./scripts/get_maintainer.pl line 277.

Git blame shows:
    git blame -L 277,+1 ./scripts/get_maintainer.pl
b67071653d3fc (Joe Perches 2016-10-28 13:22:01 +1100 277) <A0><A0><A0><A0>$sections = 1;

(A0 seems to be the no break space. That character was inserted more
often further down the patch.)

Anybody else seeing this?


Paul Bolle

2016-11-03 09:16:46

by Joe Perches

[permalink] [raw]
Subject: Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

On Thu, 2016-11-03 at 10:07 +0100, Paul Bolle wrote:
> On Mon, 2016-10-24 at 11:05 -0700, Joe Perches wrote:
> > Jani Nikula proposes patches to add a few new letter prefixes
> > for "B:" bug reporting and "C:" maintainer chatting to the
> > various sections of MAINTAINERS.
> >
> > Add a generic mechanism to get_maintainer.pl to find sections that
> > have any combination of "[A-Z]" letter prefix types in a section.
> >
> > Signed-off-by: Joe Perches <[email protected]>
>
> This patch made it into linux-next (ie, next-20161028).
>
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", ");
> > ?$output_rolestats = 1 if ($interactive);
> > ?$output_roles = 1 if ($output_rolestats);
> > ?
> > -if ($sections) {
> > +if ($sections || $letters ne "") {
> > +????$sections = 1;
>
> This triggers:
> ? ??Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at ./scripts/get_maintainer.pl line 277.
>
> Git blame shows:
> ? ??git blame -L 277,+1 ./scripts/get_maintainer.pl
> b67071653d3fc (Joe Perches 2016-10-28 13:22:01 +1100 277) <A0><A0><A0><A0>$sections = 1;
>
> (A0 seems to be the no break space. That character was inserted more
> often further down the patch.)
>
> Anybody else seeing this?

Yes, it's been reported and should be fixed in -mm.
The fix should show up in -next in a little bit.

For now, try:
$ sed -i -e 's/\xA0/ /g' scripts/get_maintainer.pl

cheers, Joe

2016-11-03 09:18:16

by Paul Bolle

[permalink] [raw]
Subject: Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

On Thu, 2016-11-03 at 02:16 -0700, Joe Perches wrote:
> Yes, it's been reported and should be fixed in -mm.
> The fix should show up in -next in a little bit.

Great.

> For now, try:
> $ sed -i -e 's/\xA0/ /g' scripts/get_maintainer.pl

Thanks,


Paul Bolle