2016-11-03 09:47:54

by Paul Bolle

[permalink] [raw]
Subject: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)

Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
hostprogs") correctly noted
[...] that because $(USERINCLUDE) isn't exported by
the top-level Makefile it's actually empty in arch/x86/boot/Makefile.

So let's do the sane thing and remove the reference to that make variable.

Signed-off-by: Paul Bolle <[email protected]>
---
arch/x86/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 12ea8f8384f4..0d810fb15eac 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -65,7 +65,7 @@ clean-files += cpustr.h

# ---------------------------------------------------------------------------

-KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
+KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
GCOV_PROFILE := n
UBSAN_SANITIZE := n
--
2.7.4


2016-11-03 09:51:43

by Paul Bolle

[permalink] [raw]
Subject: Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)

Apparently Matt left Intel. Let's forward this to a recently used
address.

On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> hostprogs") correctly noted
>     [...] that because $(USERINCLUDE) isn't exported by
>     the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
>
> So let's do the sane thing and remove the reference to that make variable.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
>  arch/x86/boot/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 12ea8f8384f4..0d810fb15eac 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -65,7 +65,7 @@ clean-files += cpustr.h
>  
>  # ---------------------------------------------------------------------------
>  
> -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
>  KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
>  GCOV_PROFILE := n
>  UBSAN_SANITIZE := n

2016-11-03 21:26:51

by Matt Fleming

[permalink] [raw]
Subject: Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)

On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote:
> Apparently Matt left Intel. Let's forward this to a recently used
> address.
>
> On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> > hostprogs") correctly noted
> > ????[...] that because $(USERINCLUDE) isn't exported by
> > ????the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
> >
> > So let's do the sane thing and remove the reference to that make variable.
> >
> > Signed-off-by: Paul Bolle <[email protected]>
> > ---
> > ?arch/x86/boot/Makefile | 2 +-
> > ?1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 12ea8f8384f4..0d810fb15eac 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -65,7 +65,7 @@ clean-files += cpustr.h
> > ?
> > ?# ---------------------------------------------------------------------------
> > ?
> > -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> > +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
> > ?KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
> > ?GCOV_PROFILE := n
> > ?UBSAN_SANITIZE := n

Looks OK to me.

Reviewed-by: Matt Fleming <[email protected]>

Subject: [tip:x86/boot] x86/boot/build: Remove always empty $(USERINCLUDE)

Commit-ID: 0acba3f91823a5e53a54af5dc31fc774b0e64e99
Gitweb: http://git.kernel.org/tip/0acba3f91823a5e53a54af5dc31fc774b0e64e99
Author: Paul Bolle <[email protected]>
AuthorDate: Thu, 3 Nov 2016 10:47:48 +0100
Committer: Ingo Molnar <[email protected]>
CommitDate: Mon, 7 Nov 2016 07:30:01 +0100

x86/boot/build: Remove always empty $(USERINCLUDE)

Commmit b6eea87fc685:

("x86, boot: Explicitly include autoconf.h for hostprogs")

correctly noted:

[...] that because $(USERINCLUDE) isn't exported by
the top-level Makefile it's actually empty in arch/x86/boot/Makefile.

So let's do the sane thing and remove the reference to that make variable.

Signed-off-by: Paul Bolle <[email protected]>
Reviewed-by: Matt Fleming <[email protected]>
Cc: David Howells <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 12ea8f8..0d810fb 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -65,7 +65,7 @@ clean-files += cpustr.h

# ---------------------------------------------------------------------------

-KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
+KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
GCOV_PROFILE := n
UBSAN_SANITIZE := n