2016-11-08 01:53:39

by Masahiro Yamada

Subject: [PATCH] s390: remove unneeded dependency for gen_facilities

The dependency between the object and the source is handled by
scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
is fine.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/s390/tools/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
index 6d9814c..4b5e1e4 100644
--- a/arch/s390/tools/Makefile
+++ b/arch/s390/tools/Makefile
@@ -9,7 +9,5 @@ define filechk_facilities.h
$(obj)/gen_facilities
endef

-$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
-
include/generated/facilities.h: $(obj)/gen_facilities FORCE
$(call filechk,facilities.h)
--
1.9.1

2016-11-08 07:45:41

by Heiko Carstens

Subject: Re: [PATCH] s390: remove unneeded dependency for gen_facilities

On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote:
> The dependency between the object and the source is handled by
> scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
> is fine.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/s390/tools/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> index 6d9814c..4b5e1e4 100644
> --- a/arch/s390/tools/Makefile
> +++ b/arch/s390/tools/Makefile
> @@ -9,7 +9,5 @@ define filechk_facilities.h
> $(obj)/gen_facilities
> endef
>
> -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
> -
> include/generated/facilities.h: $(obj)/gen_facilities FORCE
> $(call filechk,facilities.h)

Acked-by: Heiko Carstens <[email protected]>

Martin, can you pick this one up too, please?

2016-11-08 08:51:09

by Martin Schwidefsky

Subject: Re: [PATCH] s390: remove unneeded dependency for gen_facilities

On Tue, 8 Nov 2016 08:45:28 +0100
Heiko Carstens <[email protected]> wrote:

> On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote:
> > The dependency between the object and the source is handled by
> > scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
> > is fine.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > arch/s390/tools/Makefile | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> > index 6d9814c..4b5e1e4 100644
> > --- a/arch/s390/tools/Makefile
> > +++ b/arch/s390/tools/Makefile
> > @@ -9,7 +9,5 @@ define filechk_facilities.h
> > $(obj)/gen_facilities
> > endef
> >
> > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
> > -
> > include/generated/facilities.h: $(obj)/gen_facilities FORCE
> > $(call filechk,facilities.h)
>
> Acked-by: Heiko Carstens <[email protected]>
>
> Martin, can you pick this one up too, please?

Done.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.