2016-11-09 09:50:04

by Andreas Larsson

Subject: [PATCH] sparc32: Fix inverted invalid_frame_pointer checks on sigreturns

Signed-off-by: Andreas Larsson <[email protected]>
---
arch/sparc/kernel/signal_32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sparc/kernel/signal_32.c b/arch/sparc/kernel/signal_32.c
index c3c12ef..9c0c8fd 100644
--- a/arch/sparc/kernel/signal_32.c
+++ b/arch/sparc/kernel/signal_32.c
@@ -89,7 +89,7 @@ asmlinkage void do_sigreturn(struct pt_regs *regs)
sf = (struct signal_frame __user *) regs->u_regs[UREG_FP];

/* 1. Make sure we are not getting garbage from the user */
- if (!invalid_frame_pointer(sf, sizeof(*sf)))
+ if (invalid_frame_pointer(sf, sizeof(*sf)))
goto segv_and_exit;

if (get_user(ufp, &sf->info.si_regs.u_regs[UREG_FP]))
@@ -150,7 +150,7 @@ asmlinkage void do_rt_sigreturn(struct pt_regs *regs)

synchronize_user_stack();
sf = (struct rt_signal_frame __user *) regs->u_regs[UREG_FP];
- if (!invalid_frame_pointer(sf, sizeof(*sf)))
+ if (invalid_frame_pointer(sf, sizeof(*sf)))
goto segv;

if (get_user(ufp, &sf->regs.u_regs[UREG_FP]))
--
2.8.0

2016-11-11 00:48:18

by David Miller

Subject: Re: [PATCH] sparc32: Fix inverted invalid_frame_pointer checks on sigreturns

From: Andreas Larsson <[email protected]>
Date: Wed, 9 Nov 2016 10:43:05 +0100

> Signed-off-by: Andreas Larsson <[email protected]>

Sorry about that, applied.