2016-11-17 09:47:18

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: cifs mount regression in 4.8 and 4.4 stable

On Fri, Sep 23, 2016 at 07:01:45AM -0500, Seth Forshee wrote:
> On Thu, Sep 22, 2016 at 10:27:56AM -0500, Seth Forshee wrote:
> > On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote:
> > > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> > > > We've received reports from users of a cifs mount regression in our
> > > > 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing
> > > > commit
> > > > from 4.8 which was applied to 4.4 stable:
> > > >
> > > > ?a6b5058 fs/cifs: make share unaccessible at root level mountable
> > > >
> > > > Testing against 4.8-rc7 shows that the problem is present there as
> > > > well.
> > > >
> > > > Thanks,
> > > > Seth
> > > >
> > > > [1] http://bugs.launchpad.net/bugs/1626112
> > >
> > > Hello Seth,?
> > >
> > > We have identified some regressions introduced by the mentioned patch
> > > These include
> >
> > I saw those, but none of the ones already in Linus's tree fix the
> > problem.
> >
> > > a) mounting of DFS shares breaks. The fix is included in Steve's tree
> > > at
> > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233745cd59c
> > > f5853d963ad216067788a87594
> >
> > However this one isn't in Linus's tree yet.
> >
> > I'm not certain what circumstances cause the failure, but based on what
> > I see in dmesg it looks likely that this one is the fix. I'll get some
> > testing with this applied.
>
> Looks like this is is the fix we need. Thanks for your help.

What ever happened with this? Did the patch end up in Linus's tree? If
so, what was the git commit id?

thanks,

greg k-h


2016-11-17 10:12:26

by Sachin Prabhu

[permalink] [raw]
Subject: Re: cifs mount regression in 4.8 and 4.4 stable

On Thu, 2016-11-17 at 10:47 +0100, Greg Kroah-Hartman wrote:
> On Fri, Sep 23, 2016 at 07:01:45AM -0500, Seth Forshee wrote:
> >
> > On Thu, Sep 22, 2016 at 10:27:56AM -0500, Seth Forshee wrote:
> > >
> > > On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote:
> > > >
> > > > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> > > > >
> > > > > We've received reports from users of a cifs mount regression
> > > > > in our
> > > > > 4.4-based kernel, e.g. [1]. It is fixed by reverting the
> > > > > follwing
> > > > > commit
> > > > > from 4.8 which was applied to 4.4 stable:
> > > > >
> > > > >  a6b5058 fs/cifs: make share unaccessible at root level
> > > > > mountable
> > > > >
> > > > > Testing against 4.8-rc7 shows that the problem is present
> > > > > there as
> > > > > well.
> > > > >
> > > > > Thanks,
> > > > > Seth
> > > > >
> > > > > [1] http://bugs.launchpad.net/bugs/1626112
> > > >
> > > > Hello Seth, 
> > > >
> > > > We have identified some regressions introduced by the mentioned
> > > > patch
> > > > These include
> > >
> > > I saw those, but none of the ones already in Linus's tree fix the
> > > problem.
> > >
> > > >
> > > > a) mounting of DFS shares breaks. The fix is included in
> > > > Steve's tree
> > > > at
> > > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233
> > > > 745cd59c
> > > > f5853d963ad216067788a87594
> > >
> > > However this one isn't in Linus's tree yet.
> > >
> > > I'm not certain what circumstances cause the failure, but based
> > > on what
> > > I see in dmesg it looks likely that this one is the fix. I'll get
> > > some
> > > testing with this applied.
> >
> > Looks like this is is the fix we need. Thanks for your help.
>
> What ever happened with this?  Did the patch end up in Linus's
> tree?  If
> so, what
> was the git commit id?
>

Hello Greg,

The upstream commit is
Fix regression which breaks DFS mounting
d171356ff11ab1825e456dfb979755e01b3c54a1

This was marked for stable and should have been sent for inclusion in
the stable trees.

Thanks

Sachin Prabhu

> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs"
> in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

2016-11-17 10:17:35

by Aurélien Aptel

[permalink] [raw]
Subject: Re: cifs mount regression in 4.8 and 4.4 stable

Hi Greg,

Greg Kroah-Hartman <[email protected]> writes:
> What ever happened with this? Did the patch end up in Linus's tree? If
> so, what was the git commit id?

It did, commit is
d171356ff11ab1825e456dfb979755e01b3c54a1

Cheers,

--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

2016-11-17 10:30:54

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: cifs mount regression in 4.8 and 4.4 stable

On Thu, Nov 17, 2016 at 03:41:44PM +0530, Sachin Prabhu wrote:
> On Thu, 2016-11-17 at 10:47 +0100, Greg Kroah-Hartman wrote:
> > On Fri, Sep 23, 2016 at 07:01:45AM -0500, Seth Forshee wrote:
> > >
> > > On Thu, Sep 22, 2016 at 10:27:56AM -0500, Seth Forshee wrote:
> > > >
> > > > On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote:
> > > > >
> > > > > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> > > > > >
> > > > > > We've received reports from users of a cifs mount regression
> > > > > > in our
> > > > > > 4.4-based kernel, e.g. [1]. It is fixed by reverting the
> > > > > > follwing
> > > > > > commit
> > > > > > from 4.8 which was applied to 4.4 stable:
> > > > > >
> > > > > > ?a6b5058 fs/cifs: make share unaccessible at root level
> > > > > > mountable
> > > > > >
> > > > > > Testing against 4.8-rc7 shows that the problem is present
> > > > > > there as
> > > > > > well.
> > > > > >
> > > > > > Thanks,
> > > > > > Seth
> > > > > >
> > > > > > [1] http://bugs.launchpad.net/bugs/1626112
> > > > >
> > > > > Hello Seth,?
> > > > >
> > > > > We have identified some regressions introduced by the mentioned
> > > > > patch
> > > > > These include
> > > >
> > > > I saw those, but none of the ones already in Linus's tree fix the
> > > > problem.
> > > >
> > > > >
> > > > > a) mounting of DFS shares breaks. The fix is included in
> > > > > Steve's tree
> > > > > at
> > > > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233
> > > > > 745cd59c
> > > > > f5853d963ad216067788a87594
> > > >
> > > > However this one isn't in Linus's tree yet.
> > > >
> > > > I'm not certain what circumstances cause the failure, but based
> > > > on what
> > > > I see in dmesg it looks likely that this one is the fix. I'll get
> > > > some
> > > > testing with this applied.
> > >
> > > Looks like this is is the fix we need. Thanks for your help.
> >
> > What ever happened with this???Did the patch end up in Linus's
> > tree???If
> > so, what
> > was the git commit id?
> >
>
> Hello Greg,
>
> The upstream commit is
> Fix regression which breaks DFS mounting
> d171356ff11ab1825e456dfb979755e01b3c54a1
>
> This was marked for stable and should have been sent for inclusion in
> the stable trees.

Ah, good, thanks for this, yes, it's already in the released kernels.

greg k-h