2016-11-19 16:51:08

by Walt Feasel

Subject: [PATCH v2 0/3] staging: speakup: checkpatch modifications

Make Linux kernel style modifications for speakup to include:

Comment style modifications
Align parenthesis
Correct email in TODO

Walt Feasel (3):
staging: speakup: varhandlers.c Comment style modifications
staging: speakup: varhandlers.c Align parenthesis
staging: speakup: TODO Correct email

drivers/staging/speakup/TODO | 2 +-
drivers/staging/speakup/varhandlers.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)

--
v2 makes changes to correct for email format patch submission
2.1.4

2016-11-19 16:51:14

by Walt Feasel

Subject: [PATCH v2 1/3] staging: speakup: varhandlers.c Comment style modifications

Make modifications to comment style

Signed-off-by: Walt Feasel <[email protected]>
---
v2 makes changes to correct for email format patch submission

drivers/staging/speakup/varhandlers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 21186e3..5ab7245 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -266,7 +266,8 @@ int spk_set_string_var(const char *page, struct st_var_header *var, int len)
return 0;
}

-/* spk_set_mask_bits sets or clears the punc/delim/repeat bits,
+/*
+ * spk_set_mask_bits sets or clears the punc/delim/repeat bits,
* if input is null uses the defaults.
* values for how: 0 clears bits of chars supplied,
* 1 clears allk, 2 sets bits for chars
--
2.1.4

2016-11-19 16:51:22

by Walt Feasel

Subject: [PATCH v2 3/3] staging: speakup: TODO Correct email

Make email correction for [email protected]

Signed-off-by: Walt Feasel <[email protected]>
---
v2 makes changes to correct for email format patch submission

drivers/staging/speakup/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO
index 3094799..993410c 100644
--- a/drivers/staging/speakup/TODO
+++ b/drivers/staging/speakup/TODO
@@ -42,6 +42,6 @@ We prefer that you contact us on the mailing list; however, if you do
not want to subscribe to a mailing list, send your email to all of the
following:

[email protected], [email protected], [email protected] and
[email protected], [email protected], [email protected] and
[email protected].

--
2.1.4

2016-11-19 16:51:40

by Walt Feasel

Subject: [PATCH v2 2/3] staging: speakup: varhandlers.c Align parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <[email protected]>
---
v2 makes changes to correct for email format patch submission

drivers/staging/speakup/varhandlers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 5ab7245..cc98419 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -237,8 +237,7 @@ int spk_set_num_var(int input, struct st_var_header *var, int how)
if (!var_data->u.n.out_str)
l = sprintf(cp, var_data->u.n.synth_fmt, (int)val);
else
- l = sprintf(cp,
- var_data->u.n.synth_fmt, var_data->u.n.out_str[val]);
+ l = sprintf(cp, var_data->u.n.synth_fmt, var_data->u.n.out_str[val]);
synth_printf("%s", cp);
return 0;
}
--
2.1.4

2016-11-19 23:19:37

by Chris Brannon

Subject: Re: [PATCH v2 3/3] staging: speakup: TODO Correct email

Walt Feasel <[email protected]> writes:

> Make email correction for [email protected]
>
> Signed-off-by: Walt Feasel <[email protected]>

Acked-by: Chris Brannon <[email protected]>

> ---
> v2 makes changes to correct for email format patch submission
>
> drivers/staging/speakup/TODO | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO
> index 3094799..993410c 100644
> --- a/drivers/staging/speakup/TODO
> +++ b/drivers/staging/speakup/TODO
> @@ -42,6 +42,6 @@ We prefer that you contact us on the mailing list; however, if you do
> not want to subscribe to a mailing list, send your email to all of the
> following:
>
> [email protected], [email protected], [email protected] and
> [email protected], [email protected], [email protected] and
> [email protected].