2016-11-23 15:08:19

by Geliang Tang

Subject: [PATCH] PCI: altera: use builtin_platform_driver

Use builtin_platform_driver() helper to simplify the code.

Signed-off-by: Geliang Tang <[email protected]>
---
drivers/pci/host/pcie-altera.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index b0ac4df..eefcb38 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -641,8 +641,4 @@ static struct platform_driver altera_pcie_driver = {
},
};

-static int altera_pcie_init(void)
-{
- return platform_driver_register(&altera_pcie_driver);
-}
-device_initcall(altera_pcie_init);
+builtin_platform_driver(altera_pcie_driver);
--
2.9.3

2016-11-25 02:26:13

by Tan, Ley Foon

Subject: Re: [PATCH] PCI: altera: use builtin_platform_driver

On Rab, 2016-11-23 at 14:52 +0000, Geliang Tang wrote:
> Use builtin_platform_driver() helper to simplify the code.
>
> Signed-off-by: Geliang Tang <[email protected]>
Acked-by: Ley Foon Tan <[email protected]>

> ---
>  drivers/pci/host/pcie-altera.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-
> altera.c
> index b0ac4df..eefcb38 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -641,8 +641,4 @@ static struct platform_driver altera_pcie_driver
> = {
>         },
>  };
>
> -static int altera_pcie_init(void)
> -{
> -       return platform_driver_register(&altera_pcie_driver);
> -}
> -device_initcall(altera_pcie_init);
> +builtin_platform_driver(altera_pcie_driver);
> --
> 2.9.3
>

2016-12-07 20:39:11

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: altera: use builtin_platform_driver

On Wed, Nov 23, 2016 at 10:52:22PM +0800, Geliang Tang wrote:
> Use builtin_platform_driver() helper to simplify the code.
>
> Signed-off-by: Geliang Tang <[email protected]>

Thanks, Geliang. I already applied an identical patch from Wei Yongjun
that will appear in v4.10.

> ---
> drivers/pci/host/pcie-altera.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
> index b0ac4df..eefcb38 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -641,8 +641,4 @@ static struct platform_driver altera_pcie_driver = {
> },
> };
>
> -static int altera_pcie_init(void)
> -{
> - return platform_driver_register(&altera_pcie_driver);
> -}
> -device_initcall(altera_pcie_init);
> +builtin_platform_driver(altera_pcie_driver);
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html