2016-12-06 14:28:39

by Konrad Rzeszutek Wilk

Subject: [PATCH] xen/pci: Bubble up error and fix description.

The function is never called under PV guests, and only shows up
when MSI (or MSI-X) cannot be allocated. Convert the message
to include the error value.

Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>
---
arch/x86/pci/xen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index bedfab9..e1fb269 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
return 0;

error:
- dev_err(&dev->dev,
- "Xen PCI frontend has not registered MSI/MSI-X support!\n");
+ dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",
+ type == PCI_CAP_ID_MSI ? "" : "-X", irq);
return irq;
}

--
2.7.4

2016-12-06 14:34:44

by Juergen Gross

Subject: Re: [PATCH] xen/pci: Bubble up error and fix description.

On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> The function is never called under PV guests, and only shows up
> when MSI (or MSI-X) cannot be allocated. Convert the message
> to include the error value.
>
> Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>

> ---
> arch/x86/pci/xen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index bedfab9..e1fb269 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> return 0;
>
> error:
> - dev_err(&dev->dev,
> - "Xen PCI frontend has not registered MSI/MSI-X support!\n");
> + dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",
> + type == PCI_CAP_ID_MSI ? "" : "-X", irq);
> return irq;
> }
>
>

2016-12-08 06:58:35

by Juergen Gross

Subject: Re: [PATCH] xen/pci: Bubble up error and fix description.

On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> The function is never called under PV guests, and only shows up
> when MSI (or MSI-X) cannot be allocated. Convert the message
> to include the error value.
>
> Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>

Commited to xen/tip.git for-linus-4.10


Juergen

2016-12-08 18:53:24

by Konrad Rzeszutek Wilk

Subject: Re: [PATCH] xen/pci: Bubble up error and fix description.

On Thu, Dec 08, 2016 at 07:58:29AM +0100, Juergen Gross wrote:
> On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> > The function is never called under PV guests, and only shows up
> > when MSI (or MSI-X) cannot be allocated. Convert the message
> > to include the error value.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>
>
> Commited to xen/tip.git for-linus-4.10

Thank you!
>
>
> Juergen
>