2016-12-07 00:57:57

by zain wang

Subject: [PATCH v2] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

We will ignored PSR setting if panel not support it. So, in this case, we should
return from analogix_dp_enable/disable_psr() without any error code.
Let's retrun 0 instead of -EINVAL when panel not support PSR in
analogix_dp_enable/disable_psr().

Signed-off-by: zain wang <[email protected]>
---

Changes in v2:
- Remove dev_warn if panel not support PSR.

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 6e0447f..eb9bf87 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -112,7 +112,7 @@ int analogix_dp_enable_psr(struct device *dev)
struct edp_vsc_psr psr_vsc;

if (!dp->psr_support)
- return -EINVAL;
+ return 0;

/* Prepare VSC packet as per EDP 1.4 spec, Table 6.9 */
memset(&psr_vsc, 0, sizeof(psr_vsc));
@@ -135,7 +135,7 @@ int analogix_dp_disable_psr(struct device *dev)
struct edp_vsc_psr psr_vsc;

if (!dp->psr_support)
- return -EINVAL;
+ return 0;

/* Prepare VSC packet as per EDP 1.4 spec, Table 6.9 */
memset(&psr_vsc, 0, sizeof(psr_vsc));
--
1.9.1

2016-12-07 03:16:43

by Archit Taneja

Subject: Re: [PATCH v2] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

On 12/07/2016 06:27 AM, zain wang wrote:
> We will ignored PSR setting if panel not support it. So, in this case, we should
> return from analogix_dp_enable/disable_psr() without any error code.
> Let's retrun 0 instead of -EINVAL when panel not support PSR in
> analogix_dp_enable/disable_psr().

Thanks. Pushed to drm-misc after wrapping the commit
message text.

Archit

>
> Signed-off-by: zain wang <[email protected]>
> ---
>
> Changes in v2:
> - Remove dev_warn if panel not support PSR.
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 6e0447f..eb9bf87 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -112,7 +112,7 @@ int analogix_dp_enable_psr(struct device *dev)
> struct edp_vsc_psr psr_vsc;
>
> if (!dp->psr_support)
> - return -EINVAL;
> + return 0;
>
> /* Prepare VSC packet as per EDP 1.4 spec, Table 6.9 */
> memset(&psr_vsc, 0, sizeof(psr_vsc));
> @@ -135,7 +135,7 @@ int analogix_dp_disable_psr(struct device *dev)
> struct edp_vsc_psr psr_vsc;
>
> if (!dp->psr_support)
> - return -EINVAL;
> + return 0;
>
> /* Prepare VSC packet as per EDP 1.4 spec, Table 6.9 */
> memset(&psr_vsc, 0, sizeof(psr_vsc));
>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project