2022-04-25 22:26:10

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant

Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
board.

Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
index 105725a127ab..ce107fe45d7c 100644
--- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
+++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
@@ -39,6 +39,7 @@ properties:
compatible:
items:
- enum:
+ - prt,prtt1c-wfm200 # Protonic PRTT1C Board
- silabs,brd4001a # WGM160P Evaluation Board
- silabs,brd8022a # WF200 Evaluation Board
- silabs,brd8023a # WFM200 Evaluation Board
--
2.30.2


2022-04-26 09:32:48

by Jérôme Pouiller

[permalink] [raw]
Subject: Re: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant

On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> board.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> index 105725a127ab..ce107fe45d7c 100644
> --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> @@ -39,6 +39,7 @@ properties:
> compatible:
> items:
> - enum:
> + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> - silabs,brd4001a # WGM160P Evaluation Board
> - silabs,brd8022a # WF200 Evaluation Board
> - silabs,brd8023a # WFM200 Evaluation Board

I think you also have to declare this new entry in wfx_sdio_of_match,
and/or wfx_spi_of_match and wfx_spi_id.

On the WFM200 variant, the antenna is built in the chip. So I think you
can point on the same configuration than the brd8023a.


--
J?r?me Pouiller


2022-04-26 13:28:24

by Jérôme Pouiller

[permalink] [raw]
Subject: Re: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant

On Tuesday 26 April 2022 07:08:12 CEST Oleksij Rempel wrote:
> On Mon, Apr 25, 2022 at 05:38:20PM +0200, J?r?me Pouiller wrote:
> > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > > board.
> > >
> > > Signed-off-by: Oleksij Rempel <[email protected]>
> > > ---
> > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > index 105725a127ab..ce107fe45d7c 100644
> > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > @@ -39,6 +39,7 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > > - silabs,brd4001a # WGM160P Evaluation Board
> > > - silabs,brd8022a # WF200 Evaluation Board
> > > - silabs,brd8023a # WFM200 Evaluation Board
> >
> > I think you also have to declare this new entry in wfx_sdio_of_match,
> > and/or wfx_spi_of_match and wfx_spi_id.
> >
> > On the WFM200 variant, the antenna is built in the chip. So I think you
> > can point on the same configuration than the brd8023a.
>
> We have attached Molex 47950 antenna on secondary RF output. Is it still
> compatible with brd8023a?

I think it is not. You will have to provide the configuration file for
this board.


--
J?r?me Pouiller


2022-04-26 14:55:37

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant

On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > board.
> >
> > Signed-off-by: Oleksij Rempel <[email protected]>
> > ---
> > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > index 105725a127ab..ce107fe45d7c 100644
> > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > @@ -39,6 +39,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > - silabs,brd4001a # WGM160P Evaluation Board
> > - silabs,brd8022a # WF200 Evaluation Board
> > - silabs,brd8023a # WFM200 Evaluation Board
>
> I think you also have to declare this new entry in wfx_sdio_of_match,
> and/or wfx_spi_of_match and wfx_spi_id.
>
> On the WFM200 variant, the antenna is built in the chip. So I think you
> can point on the same configuration than the brd8023a.

We have attached Molex 47950 antenna on secondary RF output. Is it still
compatible with brd8023a?

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-04-26 16:47:20

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 antenna variant

On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > board.
> >
> > Signed-off-by: Oleksij Rempel <[email protected]>
> > ---
> > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > index 105725a127ab..ce107fe45d7c 100644
> > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > @@ -39,6 +39,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > - silabs,brd4001a # WGM160P Evaluation Board
> > - silabs,brd8022a # WF200 Evaluation Board
> > - silabs,brd8023a # WFM200 Evaluation Board
>
> I think you also have to declare this new entry in wfx_sdio_of_match,
> and/or wfx_spi_of_match and wfx_spi_id.
>
> On the WFM200 variant, the antenna is built in the chip. So I think you
> can point on the same configuration than the brd8023a.

I assume driver update can be made in a separate patch. As soon as we
reserved compatible for this boards there should be no conflicts. This patches
series is targeting only devicetree and needed DT schema changes.

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |