drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---
imx.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/staging/media/atomisp/i2c/imx/imx.c
+++ b/drivers/staging/media/atomisp/i2c/imx/imx.c
@@ -2483,7 +2483,6 @@ MODULE_DEVICE_TABLE(i2c, imx_ids);
static struct i2c_driver imx_driver = {
.driver = {
- .owner = THIS_MODULE,
.name = IMX_DRIVER,
},
.probe = imx_probe,
On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
> drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Alan Cox <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
May I ask which repository this patch is based on?
Does Intel finally attempt to upstream the atomisp driver?
Best regards,
Daniel
On Wed, 2017-03-01 at 22:58 +0100, Daniel Glöckner wrote:
> On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
> >
> > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to
> > set .owner here. The core will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: Alan Cox <[email protected]>
> > Signed-off-by: Fengguang Wu <[email protected]>
>
>
> May I ask which repository this patch is based on?
It's a major clean up from internal code. For various reasons the
previous history of the code can't be exposed (the internal repository
we have contains code that can't go out of Intel for example).
> Does Intel finally attempt to upstream the atomisp driver?
That's the goal for the ISP 2 driver (Baytrail/T and later
Cherrytrail). I can't speak for longer term plans with ISP 3 and later
devices which currently don't have upstream drivers. There are some
bits of support in ISP2 for some of the odder phone platforms as well
but I don't have a way to test them or think anyone cares so plan to
drop those.
Alan
On Wed, Mar 01, 2017 at 10:58:59PM +0100, Daniel Glöckner wrote:
>On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
>> drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
>>
>> Remove .owner field if calls are used which set it automatically
>>
>> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>>
>> CC: Alan Cox <[email protected]>
>> Signed-off-by: Fengguang Wu <[email protected]>
>
>
>May I ask which repository this patch is based on?
The email is replying to this one, which shows Greg's staging tree.
Date: Wed, 1 Mar 2017 18:30:16 +0800
From: kbuild test robot <[email protected]>
To: Alan Cox <[email protected]>
Cc: [email protected], Greg Kroah-Hartman <[email protected]>, [email protected]
Subject: [kbuild-all] [staging:staging-testing 209/209] drivers/staging/media/atomisp/i2c/gc2235.c:37:41: fatal error:
linux/atomisp_gmin_platform.h: No such file or directory
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head: 628b2b91d50c74e2475a11a0db5978d9a36d2026
commit: 628b2b91d50c74e2475a11a0db5978d9a36d2026 [209/209] staging/atomisp: Add support for the Intel IPU v2
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout 628b2b91d50c74e2475a11a0db5978d9a36d2026
# save the attached .config to linux build tree
make ARCH=i386
>Does Intel finally attempt to upstream the atomisp driver?
It looks so.
Thanks,
Fengguang