2017-03-08 08:30:03

by Naohiro Aota

Subject: [PATCH] uapi: add missing install of userio.h

While commit 5523662edd4f ("Input: add userio module") added userio.h
under the uapi/ directory, it forgot to add the header file to Kbuild.
Thus, the file is missing from header installation. This patch just
resolve the issue by adding the missing entry.

Signed-off-by: Naohiro Aota <[email protected]>
---
include/uapi/linux/Kbuild | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index dd9820b1c779..f8d9fed17ba9 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -445,6 +445,7 @@ header-y += unistd.h
header-y += unix_diag.h
header-y += usbdevice_fs.h
header-y += usbip.h
+header-y += userio.h
header-y += utime.h
header-y += utsname.h
header-y += uuid.h
--
2.11.0

2017-03-08 22:08:16

by Lyude

Subject: Re: [PATCH] uapi: add missing install of userio.h

Thanks for catching that!

Reviewed-by: Lyude Paul <[email protected]>

On Wed, 2017-03-08 at 17:22 +0900, Naohiro Aota wrote:
> While commit 5523662edd4f ("Input: add userio module") added userio.h
> under the uapi/ directory, it forgot to add the header file to
> Kbuild.
> Thus, the file is missing from header installation. This patch just
> resolve the issue by adding the missing entry.
>
> Signed-off-by: Naohiro Aota <[email protected]>
> ---
>  include/uapi/linux/Kbuild | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index dd9820b1c779..f8d9fed17ba9 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -445,6 +445,7 @@ header-y += unistd.h
>  header-y += unix_diag.h
>  header-y += usbdevice_fs.h
>  header-y += usbip.h
> +header-y += userio.h
>  header-y += utime.h
>  header-y += utsname.h
>  header-y += uuid.h

2017-03-24 14:49:25

by Jiri Kosina

Subject: Re: [PATCH] uapi: add missing install of userio.h

On Wed, 8 Mar 2017, Naohiro Aota wrote:

> While commit 5523662edd4f ("Input: add userio module") added userio.h
> under the uapi/ directory, it forgot to add the header file to Kbuild.
> Thus, the file is missing from header installation. This patch just
> resolve the issue by adding the missing entry.
>
> Signed-off-by: Naohiro Aota <[email protected]>

Adding Dmitry, as I believe this'd better go trough input.git for 4.11
still.

Thanks.

> ---
> include/uapi/linux/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index dd9820b1c779..f8d9fed17ba9 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -445,6 +445,7 @@ header-y += unistd.h
> header-y += unix_diag.h
> header-y += usbdevice_fs.h
> header-y += usbip.h
> +header-y += userio.h
> header-y += utime.h
> header-y += utsname.h
> header-y += uuid.h
> --
> 2.11.0
>

--
Jiri Kosina
SUSE Labs

2017-03-25 06:06:09

by Dmitry Torokhov

Subject: Re: [PATCH] uapi: add missing install of userio.h

On Fri, Mar 24, 2017 at 03:49:08PM +0100, Jiri Kosina wrote:
> On Wed, 8 Mar 2017, Naohiro Aota wrote:
>
> > While commit 5523662edd4f ("Input: add userio module") added userio.h
> > under the uapi/ directory, it forgot to add the header file to Kbuild.
> > Thus, the file is missing from header installation. This patch just
> > resolve the issue by adding the missing entry.
> >
> > Signed-off-by: Naohiro Aota <[email protected]>
>
> Adding Dmitry, as I believe this'd better go trough input.git for 4.11
> still.

Applied, thank you.

--
Dmitry