2017-03-12 18:56:30

by Bartosz Golaszewski

Subject: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it

GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.

Depend on GPIOLIB but select GPIOLIB_IRQCHIP.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/hid/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 1aeb80e..00e2809 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -214,7 +214,8 @@ config HID_CMEDIA

config HID_CP2112
tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
- depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
+ depends on USB_HID && I2C && GPIOLIB
+ select GPIOLIB_IRQCHIP
---help---
Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
This is a HID device driver which registers as an i2c adapter
--
2.9.3

2017-03-13 09:48:38

by Benjamin Tissoires

Subject: Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it

On Mar 12 2017 or thereabouts, Bartosz Golaszewski wrote:
> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
>
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---

Makes sense. Good catch

Acked-by: Benjamin Tissoires <[email protected]>

> drivers/hid/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> + depends on USB_HID && I2C && GPIOLIB
> + select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> This is a HID device driver which registers as an i2c adapter
> --
> 2.9.3
>

2017-03-21 14:31:04

by Jiri Kosina

Subject: Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it

On Sun, 12 Mar 2017, Bartosz Golaszewski wrote:

> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
>
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/hid/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> + depends on USB_HID && I2C && GPIOLIB
> + select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> This is a HID device driver which registers as an i2c adapter

Applied, thanks.

--
Jiri Kosina
SUSE Labs