2017-03-16 23:27:41

by Peter Huewe

[permalink] [raw]
Subject: [PATCH] hwmon: Add missing HWMON_T_ALARM

Unfortunately the HWMON_T_ALARM define was missing,
although the associated entry was present in hwmon_temp_attributes.
This is needed to convert drivers to the new interface which use channel
based alarms.

Signed-off-by: Peter Huewe <[email protected]>
---
include/linux/hwmon.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
index 78d59dba563e..88b673749121 100644
--- a/include/linux/hwmon.h
+++ b/include/linux/hwmon.h
@@ -88,6 +88,7 @@ enum hwmon_temp_attributes {
#define HWMON_T_CRIT_HYST BIT(hwmon_temp_crit_hyst)
#define HWMON_T_EMERGENCY BIT(hwmon_temp_emergency)
#define HWMON_T_EMERGENCY_HYST BIT(hwmon_temp_emergency_hyst)
+#define HWMON_T_ALARM BIT(hwmon_temp_alarm)
#define HWMON_T_MIN_ALARM BIT(hwmon_temp_min_alarm)
#define HWMON_T_MAX_ALARM BIT(hwmon_temp_max_alarm)
#define HWMON_T_CRIT_ALARM BIT(hwmon_temp_crit_alarm)
--
2.7.3


2017-03-17 13:44:05

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] hwmon: Add missing HWMON_T_ALARM

On Fri, Mar 17, 2017 at 12:28:56AM +0100, Peter Huewe wrote:
> Unfortunately the HWMON_T_ALARM define was missing,
> although the associated entry was present in hwmon_temp_attributes.
> This is needed to convert drivers to the new interface which use channel
> based alarms.
>
Good catch. Applied.

Thanks,
Guenter

> Signed-off-by: Peter Huewe <[email protected]>
> ---
> include/linux/hwmon.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> index 78d59dba563e..88b673749121 100644
> --- a/include/linux/hwmon.h
> +++ b/include/linux/hwmon.h
> @@ -88,6 +88,7 @@ enum hwmon_temp_attributes {
> #define HWMON_T_CRIT_HYST BIT(hwmon_temp_crit_hyst)
> #define HWMON_T_EMERGENCY BIT(hwmon_temp_emergency)
> #define HWMON_T_EMERGENCY_HYST BIT(hwmon_temp_emergency_hyst)
> +#define HWMON_T_ALARM BIT(hwmon_temp_alarm)
> #define HWMON_T_MIN_ALARM BIT(hwmon_temp_min_alarm)
> #define HWMON_T_MAX_ALARM BIT(hwmon_temp_max_alarm)
> #define HWMON_T_CRIT_ALARM BIT(hwmon_temp_crit_alarm)
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html