2017-03-20 12:39:25

by Ravi Bangoria

[permalink] [raw]
Subject: [PATCH] perf stat: Correct --no-aggr description

Description of --no-aggr in perf-stat man page is outdated. --no-aggr
can also be used while profiling specific set of cpus. For ex,

$ perf stat -e cycles,instructions -C 1-2 --no-aggr -- sleep 1

Performance counter stats for 'CPU(s) 1-2':

CPU1 5,94,92,795 cycles
CPU2 2,69,72,403 cycles
CPU1 2,02,08,327 instructions # 0.34 insn per cycle
CPU2 73,17,123 instructions # 0.12 insn per cycle

1.000989132 seconds time elapsed

Signed-off-by: Ravi Bangoria <[email protected]>
---
tools/perf/Documentation/perf-stat.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
index aecf2a8..9785481 100644
--- a/tools/perf/Documentation/perf-stat.txt
+++ b/tools/perf/Documentation/perf-stat.txt
@@ -94,8 +94,7 @@ to activate system-wide monitoring. Default is to count on all CPUs.

-A::
--no-aggr::
-Do not aggregate counts across all monitored CPUs in system-wide mode (-a).
-This option is only valid in system-wide mode.
+Do not aggregate counts across all monitored CPUs.

-n::
--null::
--
2.1.4


2017-03-20 13:39:39

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH] perf stat: Correct --no-aggr description

Em Mon, Mar 20, 2017 at 06:07:18PM +0530, Ravi Bangoria escreveu:
> Description of --no-aggr in perf-stat man page is outdated. --no-aggr
> can also be used while profiling specific set of cpus. For ex,
>
> $ perf stat -e cycles,instructions -C 1-2 --no-aggr -- sleep 1
>
> Performance counter stats for 'CPU(s) 1-2':
>
> CPU1 5,94,92,795 cycles
> CPU2 2,69,72,403 cycles
> CPU1 2,02,08,327 instructions # 0.34 insn per cycle
> CPU2 73,17,123 instructions # 0.12 insn per cycle
>
> 1.000989132 seconds time elapsed

Thanks, applied.

- Arnaldo

Subject: [tip:perf/core] perf stat: Correct --no-aggr description

Commit-ID: efc9c05681c589ed942bf8c55a774853938ca8d4
Gitweb: http://git.kernel.org/tip/efc9c05681c589ed942bf8c55a774853938ca8d4
Author: Ravi Bangoria <[email protected]>
AuthorDate: Mon, 20 Mar 2017 18:07:18 +0530
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 20 Mar 2017 15:01:31 -0300

perf stat: Correct --no-aggr description

Description of --no-aggr in perf-stat man page is outdated. --no-aggr
can also be used while profiling specific set of cpus. For ex,

$ perf stat -e cycles,instructions -C 1-2 --no-aggr -- sleep 1

Performance counter stats for 'CPU(s) 1-2':

CPU1 5,94,92,795 cycles
CPU2 2,69,72,403 cycles
CPU1 2,02,08,327 instructions # 0.34 insn per cycle
CPU2 73,17,123 instructions # 0.12 insn per cycle

1.000989132 seconds time elapsed

Signed-off-by: Ravi Bangoria <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: http://lkml.kernel.org/r/1490013438-5713-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/Documentation/perf-stat.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
index aecf2a8..9785481 100644
--- a/tools/perf/Documentation/perf-stat.txt
+++ b/tools/perf/Documentation/perf-stat.txt
@@ -94,8 +94,7 @@ to activate system-wide monitoring. Default is to count on all CPUs.

-A::
--no-aggr::
-Do not aggregate counts across all monitored CPUs in system-wide mode (-a).
-This option is only valid in system-wide mode.
+Do not aggregate counts across all monitored CPUs.

-n::
--null::