2017-03-29 03:32:19

by Daniel Cashman

Subject: [PATCH] Remove atomisp/i2c style errors.

From: Dan Cashman <[email protected]>

Remove two ' , ' issues and change spaces to tabs found by poking around in
drivers/staging/. Warnings left untouched.

Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and
after change. Errors go from 3 to 0.

Signed-off-by: Dan Cashman <[email protected]>
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
index bacffbe..8432ee9 100644
--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -606,8 +606,8 @@ static s32 ap1302_try_mbus_fmt_locked(struct v4l2_subdev *sd,


static int ap1302_get_fmt(struct v4l2_subdev *sd,
- struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_format *format)
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_format *format)

{
struct v4l2_mbus_framefmt *fmt = &format->format;
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index add8b90..1ec616a 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -54,7 +54,7 @@ static int gc0310_read_reg(struct i2c_client *client,
return -EINVAL;
}

- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));

msg[0].addr = client->addr;
msg[0].flags = 0;
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 9b41023..50f4317 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -55,7 +55,7 @@ static int gc2235_read_reg(struct i2c_client *client,
return -EINVAL;
}

- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));

msg[0].addr = client->addr;
msg[0].flags = 0;
--
2.7.4

2017-03-29 07:08:39

by Greg Kroah-Hartman

Subject: Re: [PATCH] Remove atomisp/i2c style errors.

On Tue, Mar 28, 2017 at 08:31:37PM -0700, Daniel Cashman wrote:
> From: Dan Cashman <[email protected]>

Please list what the issue you fixed in the subject line.

Also change the subject to match others for this driver, a 'git log'
will show you what to do there.

>
> Remove two ' , ' issues and change spaces to tabs found by poking around in
> drivers/staging/. Warnings left untouched.
>
> Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and
> after change. Errors go from 3 to 0.

This isn't needed, and really, you didn't test the code, only a random
perl script :)

thanks,

greg k-h

2017-03-29 16:58:17

by Daniel Cashman

Subject: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.

From: Dan Cashman <[email protected]>

Signed-off-by: Dan Cashman <[email protected]>
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
index bacffbe..8432ee9 100644
--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -606,8 +606,8 @@ static s32 ap1302_try_mbus_fmt_locked(struct v4l2_subdev *sd,


static int ap1302_get_fmt(struct v4l2_subdev *sd,
- struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_format *format)
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_format *format)

{
struct v4l2_mbus_framefmt *fmt = &format->format;
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index add8b90..1ec616a 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -54,7 +54,7 @@ static int gc0310_read_reg(struct i2c_client *client,
return -EINVAL;
}

- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));

msg[0].addr = client->addr;
msg[0].flags = 0;
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 9b41023..50f4317 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -55,7 +55,7 @@ static int gc2235_read_reg(struct i2c_client *client,
return -EINVAL;
}

- memset(msg, 0 , sizeof(msg));
+ memset(msg, 0, sizeof(msg));

msg[0].addr = client->addr;
msg[0].flags = 0;
--
2.7.4

2017-03-29 17:30:38

by Alan

Subject: Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.

On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote:
> From: Dan Cashman <[email protected]>
>
> Signed-off-by: Dan Cashman <[email protected]>


As the TODO asks - please no whitespace cleanups yet. They make it
harder to keep other cleanups that fix (or mostly remove) code
applying.

Nothing wrong with the patch otherwise - but it should also have
something in the commit message.

Alan

2017-04-02 02:50:10

by Daniel Cashman

Subject: Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.

My apologies; I did not review the TODO. Consider this withdrawn.

Dan

On 03/29/2017 10:30 AM, Alan Cox wrote:
> On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote:
>> From: Dan Cashman <[email protected]>
>>
>> Signed-off-by: Dan Cashman <[email protected]>
>
>
> As the TODO asks - please no whitespace cleanups yet. They make it
> harder to keep other cleanups that fix (or mostly remove) code
> applying.
>
> Nothing wrong with the patch otherwise - but it should also have
> something in the commit message.
>
> Alan
>