2017-04-05 19:54:00

by Ray Jui

Subject: [PATCH] clk: iproc: Remove redundant check

Remove the redundant check of 'rate' in the if statement of the
'pll_set_rate' function

Reported-by: David Binderman <[email protected]>
Signed-off-by: Ray Jui <[email protected]>
Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support")
---
drivers/clk/bcm/clk-iproc-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c
index e04634c..2d61893 100644
--- a/drivers/clk/bcm/clk-iproc-pll.c
+++ b/drivers/clk/bcm/clk-iproc-pll.c
@@ -277,7 +277,7 @@ static int pll_set_rate(struct iproc_clk *clk, unsigned int rate_index,
if (rate >= VCO_LOW && rate < VCO_HIGH) {
ki = 4;
kp_index = KP_BAND_MID;
- } else if (rate >= VCO_HIGH && rate && rate < VCO_HIGH_HIGH) {
+ } else if (rate >= VCO_HIGH && rate < VCO_HIGH_HIGH) {
ki = 3;
kp_index = KP_BAND_HIGH;
} else if (rate >= VCO_HIGH_HIGH && rate < VCO_MAX) {
--
2.1.4

2017-04-05 21:48:17

by Stephen Boyd

Subject: Re: [PATCH] clk: iproc: Remove redundant check

On 04/05, Ray Jui wrote:
> Remove the redundant check of 'rate' in the if statement of the
> 'pll_set_rate' function
>
> Reported-by: David Binderman <[email protected]>
> Signed-off-by: Ray Jui <[email protected]>
> Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support")
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project