2017-04-10 10:21:48

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling


Hi,

Philipp Zabel <[email protected]> writes:
> As of commit bb475230b8e5 ("reset: make optional functions really
> optional"), the reset framework API calls use NULL pointers to describe
> optional, non-present reset controls.
>
> This allows to return errors from devm_reset_control_get_optional and to
> call reset_control_(de)assert unconditionally.
>
> Signed-off-by: Philipp Zabel <[email protected]>
> Cc: Dinh Nguyen <[email protected]>
> Cc: John Youn <[email protected]>
> Cc: Felipe Balbi <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>

doesn't apply to testing/next. Care to rebase and resend? Also, please
Cc linux-usb ;-)

--
balbi


Attachments:
signature.asc (832.00 B)

2017-04-10 10:37:01

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

Hi Felipe,

On Mon, 2017-04-10 at 13:21 +0300, Felipe Balbi wrote:
> Hi,
>
> Philipp Zabel <[email protected]> writes:
> > As of commit bb475230b8e5 ("reset: make optional functions really
> > optional"), the reset framework API calls use NULL pointers to describe
> > optional, non-present reset controls.
> >
> > This allows to return errors from devm_reset_control_get_optional and to
> > call reset_control_(de)assert unconditionally.
> >
> > Signed-off-by: Philipp Zabel <[email protected]>
> > Cc: Dinh Nguyen <[email protected]>
> > Cc: John Youn <[email protected]>
> > Cc: Felipe Balbi <[email protected]>
> > Cc: Greg Kroah-Hartman <[email protected]>
>
> doesn't apply to testing/next. Care to rebase and resend?

v2 is already applied as commit 5a6e4f46abd5 ("usb: dwc2: simplify
optional reset handling"), as far as I can tell.

> Also, please Cc linux-usb ;-)

I messed up the Cc: list on the first submission, but v2 should have
made it to linux-usb.

regards
Philipp

2017-04-10 11:24:58

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling


Hi,

Philipp Zabel <[email protected]> writes:
>> Philipp Zabel <[email protected]> writes:
>> > As of commit bb475230b8e5 ("reset: make optional functions really
>> > optional"), the reset framework API calls use NULL pointers to describe
>> > optional, non-present reset controls.
>> >
>> > This allows to return errors from devm_reset_control_get_optional and to
>> > call reset_control_(de)assert unconditionally.
>> >
>> > Signed-off-by: Philipp Zabel <[email protected]>
>> > Cc: Dinh Nguyen <[email protected]>
>> > Cc: John Youn <[email protected]>
>> > Cc: Felipe Balbi <[email protected]>
>> > Cc: Greg Kroah-Hartman <[email protected]>
>>
>> doesn't apply to testing/next. Care to rebase and resend?
>
> v2 is already applied as commit 5a6e4f46abd5 ("usb: dwc2: simplify
> optional reset handling"), as far as I can tell.

indeed, heh :-)

>> Also, please Cc linux-usb ;-)
>
> I messed up the Cc: list on the first submission, but v2 should have
> made it to linux-usb.

cool, thanks

--
balbi


Attachments:
signature.asc (832.00 B)