2017-04-19 14:56:20

by Alexander Kochetkov

Subject: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

Commit e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
made a change resulted in clock message appears every time the card is
resuming (every 5 second in average). Add condition that previously used to
print the message.

Fixes: e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
Signed-off-by: Alexander Kochetkov <[email protected]>
---
drivers/mmc/host/dw_mmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 73db085..faaf2c1 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1178,7 +1178,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit)

if ((clock != slot->__clk_old &&
!test_bit(DW_MMC_CARD_NEEDS_POLL, &slot->flags)) ||
- force_clkinit) {
+ (force_clkinit &&
+ (slot->mmc->pm_flags & MMC_PM_KEEP_POWER))) {
dev_info(&slot->mmc->class_dev,
"Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n",
slot->id, host->bus_hz, clock,
--
1.7.9.5

2017-04-20 10:06:21

by Jaehoon Chung

Subject: Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

Hi Alexander,

On 04/19/2017 11:55 PM, Alexander Kochetkov wrote:
> Commit e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
> made a change resulted in clock message appears every time the card is
> resuming (every 5 second in average). Add condition that previously used to
> print the message.

I think you are not using the latest kernel. which version do you use?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9

Could you check this?

Best Regards,
Jaehoon Chung

>
> Fixes: e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
> Signed-off-by: Alexander Kochetkov <[email protected]>
> ---
> drivers/mmc/host/dw_mmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 73db085..faaf2c1 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1178,7 +1178,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit)
>
> if ((clock != slot->__clk_old &&
> !test_bit(DW_MMC_CARD_NEEDS_POLL, &slot->flags)) ||
> - force_clkinit) {
> + (force_clkinit &&
> + (slot->mmc->pm_flags & MMC_PM_KEEP_POWER))) {
> dev_info(&slot->mmc->class_dev,
> "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n",
> slot->id, host->bus_hz, clock,
>

2017-04-20 13:50:48

by Alexander Kochetkov

Subject: Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

> 20 апр. 2017 г., в 13:06, Jaehoon Chung <[email protected]> написал(а):
>
> I think you are not using the latest kernel. which version do you use?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9
>
> Could you check this?

Commit ce69e2fea093 («mmc: dw_mmc: silent verbose log when calling from PM context») fix
issue I have. So my patch not needed anymore.

I use 4.10.10, probably ce69e2fea093b7fa3991c87849c4955cd47796c9 should be backported to 4.10 branch.
4.9 branch doesn’t have commit e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist») what
cause the problem.

I’ll send request to stable.

Regards,
Alexander.