2017-04-23 09:39:22

by Pan Bian

Subject: [PATCH 1/1] wan: pc300too: abort path on failure

From: Pan Bian <[email protected]>

In function pc300_pci_init_one(), on the ioremap error path, function
pc300_pci_remove_one() is called to free the allocated memory. However,
the path is not terminated, and the freed memory will be used later,
resulting in use-after-free bugs. This path fixes the bug.

Signed-off-by: Pan Bian <[email protected]>
---
drivers/net/wan/pc300too.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
index e1dd1ec..b9b934b 100644
--- a/drivers/net/wan/pc300too.c
+++ b/drivers/net/wan/pc300too.c
@@ -346,6 +346,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
card->rambase == NULL) {
pr_err("ioremap() failed\n");
pc300_pci_remove_one(pdev);
+ return -ENOMEM;
}

/* PLX PCI 9050 workaround for local configuration register read bug */
--
1.9.1

2017-04-24 19:52:11

by David Miller

Subject: Re: [PATCH 1/1] wan: pc300too: abort path on failure

From: Pan Bian <[email protected]>
Date: Sun, 23 Apr 2017 17:38:35 +0800

> From: Pan Bian <[email protected]>
>
> In function pc300_pci_init_one(), on the ioremap error path, function
> pc300_pci_remove_one() is called to free the allocated memory. However,
> the path is not terminated, and the freed memory will be used later,
> resulting in use-after-free bugs. This path fixes the bug.
>
> Signed-off-by: Pan Bian <[email protected]>

Applied.