2017-04-26 13:43:31

by Boris Ostrovsky

[permalink] [raw]
Subject: [PATCH] xen/x86: Call xen_smp_intr_init_pv() on BSP

Recent code rework that split handling ov PV, HVM and PVH guests into
separate files missed calling xen_smp_intr_init_pv() on CPU0.

Add this call.

Signed-off-by: Boris Ostrovsky <[email protected]>
Reported-by: Sander Eikelenboom <[email protected]>
---
arch/x86/xen/smp_pv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index c0e3b96..aae3253 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -249,7 +249,7 @@ static void __init xen_pv_smp_prepare_cpus(unsigned int max_cpus)

xen_pmu_init(0);

- if (xen_smp_intr_init(0))
+ if (xen_smp_intr_init(0) || xen_smp_intr_init_pv(0))
BUG();

if (!alloc_cpumask_var(&xen_cpu_initialized_map, GFP_KERNEL))
--
1.8.3.1


2017-04-28 05:01:37

by Jürgen Groß

[permalink] [raw]
Subject: Re: [PATCH] xen/x86: Call xen_smp_intr_init_pv() on BSP

On 26/04/17 15:42, Boris Ostrovsky wrote:
> Recent code rework that split handling ov PV, HVM and PVH guests into
> separate files missed calling xen_smp_intr_init_pv() on CPU0.
>
> Add this call.
>
> Signed-off-by: Boris Ostrovsky <[email protected]>
> Reported-by: Sander Eikelenboom <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Thanks,

Juergen

2017-04-28 18:02:31

by Jürgen Groß

[permalink] [raw]
Subject: Re: [PATCH] xen/x86: Call xen_smp_intr_init_pv() on BSP

On 26/04/17 15:42, Boris Ostrovsky wrote:
> Recent code rework that split handling ov PV, HVM and PVH guests into
> separate files missed calling xen_smp_intr_init_pv() on CPU0.
>
> Add this call.
>
> Signed-off-by: Boris Ostrovsky <[email protected]>
> Reported-by: Sander Eikelenboom <[email protected]>

Pushed to xen/tip for-linus-4.12


Juergen