2017-06-13 14:15:36

by George Cherian

[permalink] [raw]
Subject: [PATCH-internal 0/2] Make cppc acpi driver aware of pcc subspace ids

The current cppc acpi driver works with only one pcc subspace id.
It maintains and registers only one pcc channel even if the acpi table has
different pcc subspace ids.

As per ACPI 6.2 spec all PCC registers, for all processors in the same
performance domain (as defined by _PSD), must be defined to be in the same
subspace. The series tries to address the same by making cppc acpi driver
aware of multiple possible pcc subspace ids.

Patch 1 : In preparation to share the MAX_PCC_SUBSPACE definition with cppc acpi
driver
Patch 2 : Make the cppc acpi driver aware of multiple pcc subspace ids.


George Cherian (2):
mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file
ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

drivers/acpi/cppc_acpi.c | 179 +++++++++++++++++++++++++----------------------
drivers/mailbox/pcc.c | 1 -
include/acpi/pcc.h | 1 +
3 files changed, 97 insertions(+), 84 deletions(-)

--
2.7.4


2017-06-13 14:15:41

by George Cherian

[permalink] [raw]
Subject: [PATCH-internal 1/2] mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file

Move the MAX_PCC_SUBSPACES definition to acpi/pcc.h file. In preparation to add
subspace id support for cppc_acpi driver.

Signed-off-by: George Cherian <[email protected]>
---
drivers/mailbox/pcc.c | 1 -
include/acpi/pcc.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index dd9ecd35..9987b8f 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -69,7 +69,6 @@

#include "mailbox.h"

-#define MAX_PCC_SUBSPACES 256
#define MBOX_IRQ_NAME "pcc-mbox"

static struct mbox_chan *pcc_mbox_channels;
diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
index 8caa79c..cd6ef45 100644
--- a/include/acpi/pcc.h
+++ b/include/acpi/pcc.h
@@ -13,6 +13,7 @@
#include <linux/mailbox_controller.h>
#include <linux/mailbox_client.h>

+#define MAX_PCC_SUBSPACES 256
#ifdef CONFIG_PCC
extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
int subspace_id);
--
2.7.4

2017-06-13 14:16:26

by George Cherian

[permalink] [raw]
Subject: Re: [PATCH-internal 0/2] Make cppc acpi driver aware of pcc subspace ids

Sorry Ignore this series!!!

On 06/13/2017 07:45 PM, George Cherian wrote:
> The current cppc acpi driver works with only one pcc subspace id.
> It maintains and registers only one pcc channel even if the acpi table has
> different pcc subspace ids.
>
> As per ACPI 6.2 spec all PCC registers, for all processors in the same
> performance domain (as defined by _PSD), must be defined to be in the same
> subspace. The series tries to address the same by making cppc acpi driver
> aware of multiple possible pcc subspace ids.
>
> Patch 1 : In preparation to share the MAX_PCC_SUBSPACE definition with cppc acpi
> driver
> Patch 2 : Make the cppc acpi driver aware of multiple pcc subspace ids.
>
>
> George Cherian (2):
> mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file
> ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids
>
> drivers/acpi/cppc_acpi.c | 179 +++++++++++++++++++++++++----------------------
> drivers/mailbox/pcc.c | 1 -
> include/acpi/pcc.h | 1 +
> 3 files changed, 97 insertions(+), 84 deletions(-)
>

2017-06-13 14:21:04

by George Cherian

[permalink] [raw]
Subject: Re: [PATCH-internal 1/2] mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file

Please ignore this patch the subject had -internal tag Sorry!!
Resent the proper one.



On 06/13/2017 07:45 PM, George Cherian wrote:
> Move the MAX_PCC_SUBSPACES definition to acpi/pcc.h file. In preparation to add
> subspace id support for cppc_acpi driver.
>
> Signed-off-by: George Cherian <[email protected]>
> ---
> drivers/mailbox/pcc.c | 1 -
> include/acpi/pcc.h | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index dd9ecd35..9987b8f 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -69,7 +69,6 @@
>
> #include "mailbox.h"
>
> -#define MAX_PCC_SUBSPACES 256
> #define MBOX_IRQ_NAME "pcc-mbox"
>
> static struct mbox_chan *pcc_mbox_channels;
> diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
> index 8caa79c..cd6ef45 100644
> --- a/include/acpi/pcc.h
> +++ b/include/acpi/pcc.h
> @@ -13,6 +13,7 @@
> #include <linux/mailbox_controller.h>
> #include <linux/mailbox_client.h>
>
> +#define MAX_PCC_SUBSPACES 256
> #ifdef CONFIG_PCC
> extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
> int subspace_id);
>