2017-06-21 06:33:53

by Hoegeun Kwon

[permalink] [raw]
Subject: [PATCH v3] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

Remove the error handling of bridge_node because the bridge_node is
optionally.

For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is optionally.

Signed-off-by: Hoegeun Kwon <[email protected]>
---

Hi all,

Changes for V3:
- Removed the word('required') from commit message.

Changes for V2:
- Modified the commit message in more detail than before.

Best regards,
Hoegeun

drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index a11b795..6ee0dac 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
return ret;

dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
- if (!dsi->bridge_node)
- return -EINVAL;

return 0;
}
--
1.9.1


2017-06-21 06:35:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

On Wed, Jun 21, 2017 at 8:33 AM, Hoegeun Kwon <[email protected]> wrote:
> Remove the error handling of bridge_node because the bridge_node is
> optionally.

"is optional"

>
> For example, In case of Exynos SoC, a bridge device such as mDNIe and
> MIC could be placed between Display Controller and MIPI DSI device but
> the bridge device is optionally.

Ditto.

BR,
Krzysztof