2017-06-21 19:16:50

by Frank Rowand

Subject: [PATCH] of: make __of_attach_node() static

From: Frank Rowand <[email protected]>

__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.

Signed-off-by: Frank Rowand <[email protected]>
---
drivers/of/dynamic.c | 2 +-
drivers/of/of_private.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 888fdbc09992..0542cf8b6e3d 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -216,7 +216,7 @@ int of_property_notify(int action, struct device_node *np,
return of_reconfig_notify(action, &pr);
}

-void __of_attach_node(struct device_node *np)
+static void __of_attach_node(struct device_node *np)
{
const __be32 *phandle;
int sz;
diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
index 4ebb0149d118..dd535365b5d2 100644
--- a/drivers/of/of_private.h
+++ b/drivers/of/of_private.h
@@ -90,7 +90,6 @@ extern int __of_update_property(struct device_node *np,
extern void __of_update_property_sysfs(struct device_node *np,
struct property *newprop, struct property *oldprop);

-extern void __of_attach_node(struct device_node *np);
extern int __of_attach_node_sysfs(struct device_node *np);
extern void __of_detach_node(struct device_node *np);
extern void __of_detach_node_sysfs(struct device_node *np);
--
Frank Rowand <[email protected]>

2017-06-22 16:17:11

by Rob Herring (Arm)

Subject: Re: [PATCH] of: make __of_attach_node() static

On Wed, Jun 21, 2017 at 12:16:38PM -0700, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> __of_attach_node() is not used outside of drivers/of/dynamic.c. Make
> it static and remove it from drivers/of/of_private.h.
>
> Signed-off-by: Frank Rowand <[email protected]>
> ---
> drivers/of/dynamic.c | 2 +-
> drivers/of/of_private.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)

Applied.