2017-06-21 19:20:23

by Frank Rowand

Subject: [PATCH] of: be consistent in form of file mode

From: Frank Rowand <[email protected]>

checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that pending patch.
Change other instances of the S_* constants in the same file to
the octal form.

Signed-off-by: Frank Rowand <[email protected]>
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 28d5f53bc631..974d51269a02 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -155,7 +155,7 @@ int __of_add_property_sysfs(struct device_node *np, struct property *pp)

sysfs_bin_attr_init(&pp->attr);
pp->attr.attr.name = safe_name(&np->kobj, pp->name);
- pp->attr.attr.mode = secure ? S_IRUSR : S_IRUGO;
+ pp->attr.attr.mode = secure ? 0400 : 0444;
pp->attr.size = secure ? 0 : pp->length;
pp->attr.read = of_node_property_read;

--
Frank Rowand <[email protected]>

2017-06-22 16:17:28

by Rob Herring (Arm)

Subject: Re: [PATCH] of: be consistent in form of file mode

On Wed, Jun 21, 2017 at 12:20:03PM -0700, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> checkpatch whined about using S_IRUGO instead of octal equivalent
> when adding phandle sysfs code, so used octal in that pending patch.
> Change other instances of the S_* constants in the same file to
> the octal form.
>
> Signed-off-by: Frank Rowand <[email protected]>
> ---
> drivers/of/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied.