2017-06-22 06:44:47

by Jaya Durga

Subject: [PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

From: Jaya Durga <[email protected]>

Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x'
may be better as '(x)' to avoid precedence issues.

Signed-off-by: Jaya Durga <[email protected]>
---
drivers/staging/rtl8712/osdep_intf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
index 5d37e1f..1985423 100644
--- a/drivers/staging/rtl8712/osdep_intf.h
+++ b/drivers/staging/rtl8712/osdep_intf.h
@@ -29,7 +29,7 @@
#include "osdep_service.h"
#include "drv_types.h"

-#define RND4(x) (((x >> 2) + (((x & 3) == 0) ? 0 : 1)) << 2)
+#define RND4(x) ((((x) >> 2) + ((((x) & 3) == 0) ? 0 : 1)) << 2)

struct intf_priv {
u8 *intf_dev;
--
1.9.1

2017-06-23 20:24:03

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

On Thu, Jun 22, 2017 at 12:10:04PM +0530, Jaya Durga wrote:
> From: Jaya Durga <[email protected]>
>
> Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x'
> may be better as '(x)' to avoid precedence issues.
>
> Signed-off-by: Jaya Durga <[email protected]>
> ---
> drivers/staging/rtl8712/osdep_intf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
> index 5d37e1f..1985423 100644
> --- a/drivers/staging/rtl8712/osdep_intf.h
> +++ b/drivers/staging/rtl8712/osdep_intf.h
> @@ -29,7 +29,7 @@
> #include "osdep_service.h"
> #include "drv_types.h"
>
> -#define RND4(x) (((x >> 2) + (((x & 3) == 0) ? 0 : 1)) << 2)
> +#define RND4(x) ((((x) >> 2) + ((((x) & 3) == 0) ? 0 : 1)) << 2)

Why not move this to use the in-kernel macros instead?

thanks,

greg k-h